Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zigbee): Add pressure, flow, ccupancy and carbon dioxide sensor #10720

Merged
merged 12 commits into from
Dec 14, 2024
Merged

feat(zigbee): Add pressure, flow, ccupancy and carbon dioxide sensor #10720

merged 12 commits into from
Dec 14, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Dec 12, 2024 •
edited
Loading

Description of Change

This PR adds 4 new endpoint types:

  • Pressure sensor
  • Flow sensor
  • Occupancy sensor
  • Carbon dioxide (CO2)

There are 3 new examples: Pressure+Flow sensor, Occupancy sensor, Carbon dioxide sensor

  • Some minor enhancements.

Tests scenarios

Tested using C6 + HomeAssistant

Related links

Closes #10684

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Libraries Issue is related to Library support. label Dec 12, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.1.0 milestone Dec 12, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Apply suggestions from code review":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
⚠️ Please consider squashing your 12 commits (simplifying branch history).
⚠️ 
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.
Messages
📖 This PR seems to be quite large (total lines of code: 1237), you might consider splitting it into smaller PRs

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against b6d0553

@P-R-O-C-H-Y P-R-O-C-H-Y linked an issue Dec 12, 2024 that may be closed by this pull request
Motion sensor example for Zigee #10684
Closed
1 task
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C60‼️ +21K0.00‼️ +3.90💚 -476⚠️ +604💚 -1.44‼️ +2.03
ESP32H20‼️ +16K0.00‼️ +2.96💚 -596⚠️ +468💚 -1.84‼️ +1.61
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_CarbonDioxide_Sensor----
Zigbee/examples/Zigbee_Color_Dimmable_Light‼️ +21K⚠️ +588‼️ +16K⚠️ +444
Zigbee/examples/Zigbee_Color_Dimmer_Switch‼️ +13K💚 -148‼️ +9K💚 -276
Zigbee/examples/Zigbee_Occupancy_Sensor----
Zigbee/examples/Zigbee_On_Off_Light‼️ +20K⚠️ +604‼️ +16K⚠️ +468
Zigbee/examples/Zigbee_On_Off_Switch‼️ +13K💚 -172‼️ +9K💚 -276
Zigbee/examples/Zigbee_Pressure_Flow_Sensor----
Zigbee/examples/Zigbee_Scan_Networks‼️ +17K⚠️ +176‼️ +12K0
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy‼️ +18K💚 -104‼️ +13K💚 -296
Zigbee/examples/Zigbee_Temperature_Sensor‼️ +15K💚 -132‼️ +11K💚 -292
Zigbee/examples/Zigbee_Thermostat‼️ +15K💚 -476‼️ +10K💚 -596

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Review needed Issue or PR is awaiting review label Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

Test Results

 62 files   62 suites   5m 41s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
154 runs  154 ✅ 0 💤 0 ❌

Results for commit b6d0553.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y P-R-O-C-H-Y changed the title feat(zigbee): Add pressure, flow and occupancy sensor feat(zigbee): Add pressure, flow, ccupancy and carbon dioxide sensor Dec 13, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y force-pushed the feat/zigbee-multi-sensor branch from 57cb75c to ceb46df Compare December 13, 2024 10:44
@P-R-O-C-H-Y P-R-O-C-H-Y force-pushed the feat/zigbee-multi-sensor branch from ceb46df to 44e1559 Compare December 13, 2024 10:47
P-R-O-C-H-Y and others added 2 commits December 13, 2024 17:07
@P-R-O-C-H-Y @lucasssvaz
Apply suggestions from code review
a7e2e64 
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
@P-R-O-C-H-Y
fix(zigbee): fix formatting of defines
6bc971c
@P-R-O-C-H-Y
Copy link
Member Author

@lucasssvaz done

@SuGlider SuGlider added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Dec 13, 2024
@me-no-dev me-no-dev merged commit 417c7ee into espressif:release/v3.1.x Dec 14, 2024
52 checks passed
@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this pull request Dec 16, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider SuGlider approved these changes

@lucasssvaz lucasssvaz lucasssvaz approved these changes

@me-no-dev me-no-dev me-no-dev approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Libraries Issue is related to Library support. Status: Pending Merge Pull Request is ready to be merged
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Motion sensor example for Zigee
4 participants
@P-R-O-C-H-Y @me-no-dev @lucasssvaz @SuGlider