-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(hw): Fix files being overwritten #11019
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 12m 46s ⏱️ Results for commit f09853a. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
ef4cc82
to
93074de
Compare
@lucasssvaz - Was HIL intended to pass? |
No BC the HW runners still not functioning properly |
@lucasssvaz - Should it be merged for the 3.2 RC2? Move it "merge pending" |
@SuGlider no. This is CI thing and we should merge it when the runners are OK, else we will get failed CI. @lucasssvaz maybe we could make it "Draft" for the time being? |
The runners are already failing and we don't have control of the runners to fix it. This PR won't change that. We can keep it as draft but I don't think it will change much. |
@lucasssvaz so we can merge it then and there will be no change until runners are fixed? |
@me-no-dev yeah. Already reported it to the CI team but no updates for now. Some other project alters the board config in such a way that the runner can't see the board connected to it anymore. AFAIK the only way to fix it is resetting the runner. IDK the specifics but @tomassebestik might be able to give more information. |
Description of Change
Fix files being overwritten that were affecting HW runners.
Tests scenarios
Locally and CI