Skip to content

fix(uart): Fixes UART CI script to work with Arduino Core 3.2.x #11077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 17, 2025
Merged

fix(uart): Fixes UART CI script to work with Arduino Core 3.2.x #11077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f2bc23d
fix(uart): ci uart test fail on esp32s2 after uart break
SuGlider Mar 12, 2025
d3f51ee
fix(uart): ci error with change pins test on ESP32
SuGlider Mar 12, 2025
7e75bba
fix(uart): ci test with perimgr using esp32 fails
SuGlider Mar 12, 2025
e6a0b20
feat(uart): avoid electrical noise before setting pins
SuGlider Mar 12, 2025
6be85a3
fix(uart_ci): fixes the UART CI sketch due to IDF 5.3 pull up change
SuGlider Mar 14, 2025
28564ea
fix(uart_ci): keeping previous formatting and applying changes
SuGlider Mar 14, 2025
f1412d6
Merge branch 'master' into fix/uart_ci_test
SuGlider Mar 14, 2025
6b2965d
feat(uart_ci): trick for passing esp32 wokwi ci test
SuGlider Mar 16, 2025
9ea4051
feat(uart_ci): reverting the wokwi patch, once it didn't make any dif…
SuGlider Mar 16, 2025
e27dcc3
fix(wokwi): Change CPU freq to 80
lucasssvaz Mar 17, 2025
c8f54f9
fix(wokwi): Change CPU freq to 120
lucasssvaz Mar 17, 2025
f89af6c
Merge branch 'master' into fix/uart_ci_test
me-no-dev Mar 17, 2025
a304ea1
ci(pre-commit): Apply automatic fixes
pre-commit-ci-lite[bot] Mar 17, 2025
293d0bf
fix(uart_ci): fixes a couple typos in commentatries
SuGlider Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/validation/uart/diagram.esp32.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"type": "board-esp32-devkit-c-v4",
"id": "esp",
"attrs": { "cpuFrequency": "40" }
"attrs": { "cpuFrequency": "120" }
}
],
"connections": [
Expand Down
4 changes: 4 additions & 0 deletions tests/validation/uart/uart.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ public:
: uart_num(num), serial(serial_ref), peeked_char(-1), default_rx_pin(rx_pin), default_tx_pin(tx_pin), recv_msg("") {}

void begin(unsigned long baudrate) {
// pinMode will force enabling the internal pullup resistor (IDF 5.3.2 Change)
pinMode(default_rx_pin, INPUT_PULLUP);
serial.begin(baudrate, SERIAL_8N1, default_rx_pin, default_tx_pin);
while (!serial) {
delay(10);
Expand Down Expand Up @@ -365,6 +367,8 @@ void change_pins_test(void) {

if (TEST_UART_NUM == 1) {
UARTTestConfig &config = *uart_test_configs[0];
// pinMode will force enabling the internal pullup resistor (IDF 5.3.2 Change)
pinMode(NEW_RX1, INPUT_PULLUP);
config.serial.setPins(NEW_RX1, NEW_TX1);
TEST_ASSERT_EQUAL(NEW_RX1, uart_get_RxPin(config.uart_num));
TEST_ASSERT_EQUAL(NEW_TX1, uart_get_TxPin(config.uart_num));
Expand Down
Loading