-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(esp32s3usbotg) stdbool dependency in pins_arduino.h #11155
Conversation
👋 Hello Marnek, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nit-picking a little bit, the comment is unnecessary as the only reason it crashes is that the header is missing and bool
is used in line 93: https://github.com/espressif/arduino-esp32/blob/master/variants/esp32s3usbotg/pins_arduino.h#L93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @lucasssvaz
esp32s3usbotg/pins_arduino.h:5:1: note: 'bool' is defined in header '<stdbool.h>'; did you forget to '#include <stdbool.h>'?
4 | #include <stdint.h>
+++ |+#include <stdbool.h>
5 |
This is a sample error from compilation of all ESP32>USB examples when targeting the ESP32-S3 with OTG board.
Adding the dependency directly in the arduino project does not mitigate the issue :(
The only fix I managed to find is to edit it directly in the pin definitions header
P.S.: a previous pull was created for the base esp32 board, but it was suggested to be requested for merge on the variant itself