fix(net): Use network_event_handle_t for internal callbacks #11179
Conversation
👋 Hello me-no-dev, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Test Results 76 files 76 suites 12m 41s ⏱️ Results for commit ce0a3bb. ♻️ This comment has been updated with latest results. |
P-R-O-C-H-Y
added
Status: Pending Merge
This pull request includes several changes aimed at improving event handling for network interfaces in the Ethernet, PPP, and WiFi libraries. The most important changes involve adding and managing event handles to ensure proper event registration and deregistration.
Event Handling Improvements:
libraries/Ethernet/src/ETH.cppandlibraries/Ethernet/src/ETH.h: Added_eth_connected_event_handleto handle Ethernet connection events. Updated methods to use this handle for event registration and removal. [1] [2] [3] [4] [5]libraries/PPP/src/PPP.cppandlibraries/PPP/src/PPP.h: Introduced_ppp_event_handleto manage PPP connection events. Modified relevant methods to utilize this handle for event management. [1] [2] [3] [4]libraries/WiFi/src/AP.cppandlibraries/WiFi/src/WiFiAP.h: Implemented_wifi_ap_event_handlefor handling WiFi AP events. Adjusted methods to register and remove events using this handle. [1] [2] [3] [4]libraries/WiFi/src/STA.cppandlibraries/WiFi/src/WiFiSTA.h: Added_wifi_sta_event_handleto manage WiFi STA events. Updated methods to handle event registration and removal with this handle. [1] [2] [3]