Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arduino_pins): fixes Lolin-C3-Pico and C3-Mini RGB LED pin + C3-Pico SPI SCK pin definition #11186

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

SuGlider
Copy link
Collaborator

Description of Change

Based on https://www.wemos.cc/en/latest/c3/c3_pico.html there were a few pin setting errors for the Lolin-C3-Pico board.
It also fixes the RGB Pin of the Lolin-C3-Mini board, as defned in https://www.wemos.cc/en/latest/c3/c3_mini.html

Tests scenarios

CI only

Related links

#11184

@SuGlider SuGlider self-assigned this Mar 27, 2025
Copy link
Contributor

github-actions bot commented Mar 27, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 95eeb03

@SuGlider SuGlider added Type: 3rd party Boards Status: Review needed Issue or PR is awaiting review labels Mar 27, 2025
@SuGlider SuGlider added this to the 3.2.0 milestone Mar 27, 2025
@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Mar 27, 2025
@me-no-dev me-no-dev merged commit 1ca9dab into master Mar 27, 2025
15 of 16 checks passed
@me-no-dev me-no-dev deleted the lolin-c3-pico-pin-fix branch March 27, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
Development

Successfully merging this pull request may close these issues.

3 participants