Skip to content

feat(SDFS): Add destructor for SD card to clean up resources #11521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 30, 2025
Merged

feat(SDFS): Add destructor for SD card to clean up resources #11521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
49af25a
feat(test): Enhance NVS test
JakubAndrysek Jun 18, 2025
e15e7f7
fix(nvs): Remove unused Unity header and improve Serial wait loop
JakubAndrysek Jun 18, 2025
e14204c
refactor(nvs): Extract string increment logic into a separate function
JakubAndrysek Jun 18, 2025
834e85c
Merge branch 'master' into test_nvs
JakubAndrysek Jun 19, 2025
3b64575
Merge pull request #2 from JakubAndrysek/test_nvs
JakubAndrysek Jun 19, 2025
13aac76
refactor(test): Format long strings in expect_exact calls for better …
JakubAndrysek Jun 19, 2025
20116fd
Merge pull request #3 from JakubAndrysek/test_nvs
JakubAndrysek Jun 19, 2025
226230f
Merge branch 'espressif:master' into master
JakubAndrysek Jun 23, 2025
444a622
Merge branch 'espressif:master' into master
JakubAndrysek Jun 26, 2025
7fabe3b
feat(SDFS): Add destructor to clean up resources
JakubAndrysek Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions libraries/SD/src/SD.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ using namespace fs;

SDFS::SDFS(FSImplPtr impl) : FS(impl), _pdrv(0xFF) {}

SDFS::~SDFS() {
end();
}

bool SDFS::begin(uint8_t ssPin, SPIClass &spi, uint32_t frequency, const char *mountpoint, uint8_t max_files, bool format_if_empty) {
if (_pdrv != 0xFF) {
return true;
Expand Down
1 change: 1 addition & 0 deletions libraries/SD/src/SD.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ class SDFS : public FS {

public:
SDFS(FSImplPtr impl);
~SDFS();
bool begin(
uint8_t ssPin = SS, SPIClass &spi = SPI, uint32_t frequency = 4000000, const char *mountpoint = "/sd", uint8_t max_files = 5, bool format_if_empty = false
);
Expand Down
Loading