Fix wifi persistent #1404
Closed
Fix wifi persistent #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiFi config is currently written to NVS regardless of if WiFi.persistent(false); was called before or not. This PR moves some of the static functions in WiFiGeneric.cpp into the WiFiGenericClass to give them access to the _persistent member. Additionally WiFi.getMode() and WiFi.mode() have been made regular methods instead of static. Now esp_wifi_set_storage(WIFI_STORAGE_RAM); is called when persistent storage is switched off.
|
this change breaks ETH, will come up with a better fix.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WiFi config is currently written to NVS regardless of if
WiFi.persistent(false);was called before or not. This PR moves some of the static functions in WiFiGeneric.cpp into the WiFiGenericClass to give them access to the _persistent member. AdditionallyWiFi.getMode()andWiFi.mode()have been made regular methods instead of static. Nowesp_wifi_set_storage(WIFI_STORAGE_RAM);is called when persistent storage is switched off.