Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restores compatibility with preexisting Arduino libraries that use Wire(). The ReSTART queuing operation is now hidden.
Wire.endTransmission(id,len,FALSE);
now returnsI2C_ERROR_OK
(0) to indicate success, though,Wire.lastError()
will correctly returnI2C_ERROR_CONTINUE
to indicate the lastWire()
operation was added to the command queue, and not executed. SinceWire.lastError()
does not exist in main branch Arduino, this dichotomy is not obvious.The number of queued operation is limited by the depth of the
Wire()
Tx/Rx buffers, currently 128 bytes each. EachWire.Write()
operation uses one byte of the Tx buffer,Wire.requestFrom(id,LEN,false);
usesLEN
bytes of the 128byte Rx buffer. If either buffer is exhausted before a STOP condition is issued,I2C_ERROR_MEMORY
will be returned.