Abortable Arduino delay() #3227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanisoft
reviewed
Sep 18, 2019
|
Why do you want to abort delay that you called yourself? If you need to cancel a delay, then you should not use delay to begin with. Will not agree with this PR. Sorry |
|
Verdict heard :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is (seems to be?) no way to break out of the Arduino
delay()equivalent implementation on ESP32 Arduino core.This PR proposes a different FreeRTOS method of implementing task delay, that allows resuming the loop() task (or any other task using Arduino-style sketches with
delay()).Measured timings for very short delay values, that is 0, 1, 2µs, are identical to the replaced code.