Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESP32-Solo WDT on HTTP OTA update #5426

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Conversation

arendst
Copy link
Contributor

@arendst arendst commented Jul 20, 2021

ESP32-Solo without these changes will report below on executing HTTP OTA update:

E (72016) task_wdt: Task watchdog got triggered. The following tasks did not reset the watchdog in time:
E (72016) task_wdt:  - IDLE0 (CPU 0)
E (72016) task_wdt: Tasks currently running:
E (72016) task_wdt: CPU 0: loopTask
E (72016) task_wdt: Aborting.
abort() was called at PC 0x401641e8 on core 0

With these changes HTTP OTA update finish succesfully.

(Tested with Tasmota on ESP32-Solo-1)

cores/esp32/Esp.cpp Outdated Show resolved Hide resolved
@me-no-dev me-no-dev added the Status: Test needed Issue needs testing label Nov 9, 2021
@Jason2866 Jason2866 mentioned this pull request May 3, 2022
1 task
@mrengineer7777
Copy link
Collaborator

I wonder if this would work just as well to prevent WDT timeouts? I use this in a couple of background threads.
vPortYield(); //Allow other tasks to run

@CLAassistant
Copy link

CLAassistant commented May 6, 2023

CLA assistant check
All committers have signed the CLA.

@VojtechBartoska VojtechBartoska added Status: Review needed Issue or PR is awaiting review and removed Status: Test needed Issue needs testing labels Jan 24, 2024
Copy link
Contributor

github-actions bot commented Jan 24, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Fix ESP32-Solo WDT on HTTP OTA update":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix ESP32-Solo WDT on HTTP OTA update":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix commits":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 5 commits (simplifying branch history).

👋 Hello arendst, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 44a15af

@lucasssvaz
Copy link
Collaborator

@arendst Please sign the CLA

@lucasssvaz lucasssvaz added the Resolution: Awaiting response Waiting for response of author label Jan 24, 2024
@lucasssvaz lucasssvaz added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jan 26, 2024
@VojtechBartoska VojtechBartoska removed the Resolution: Awaiting response Waiting for response of author label Jan 30, 2024
@VojtechBartoska VojtechBartoska added this to the 3.0.0-RC1 milestone Jan 30, 2024
@me-no-dev me-no-dev added Resolution: Awaiting response Waiting for response of author and removed Status: Pending Merge Pull Request is ready to be merged labels Jan 31, 2024
@VojtechBartoska
Copy link
Contributor

Hello @arendst, can you please sign CLA so we can merge this PR. Thanks a lot!

@me-no-dev me-no-dev merged commit bbbbec9 into espressif:master Feb 7, 2024
52 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Awaiting response Waiting for response of author
Projects
Development

Successfully merging this pull request may close these issues.

7 participants