Skip to content

Add Github action for uploading arduino-esp32 component. #6203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

magicarm22
Copy link
Contributor

@magicarm22 magicarm22 commented Jan 28, 2022

Summary

Add upload-idf-componen.yml file for Github Workflow. After each push on the master branch, the component will be uploaded to the component registry

Impact

After that PR users can use the Arduino-ESP32 component from the component registry.

@CLAassistant
Copy link

CLAassistant commented Jan 28, 2022

CLA assistant check
All committers have signed the CLA.

@magicarm22 magicarm22 changed the title Feature/idf component Add Github action for uploading arduino-esp32 component. Jan 28, 2022
Copy link
Contributor

@kumekay kumekay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave only one commit in this PR

@magicarm22 magicarm22 force-pushed the feature/idf_component branch 4 times, most recently from d83c162 to 49f9978 Compare January 28, 2022 15:14
@magicarm22 magicarm22 force-pushed the feature/idf_component branch 2 times, most recently from 87fd8e3 to 6c0e561 Compare January 28, 2022 16:35
@kumekay
Copy link
Contributor

kumekay commented Jan 28, 2022

Thank you @magicarm22 , LGTM

@me-no-dev Could you please take a look? Are there any files that should be excluded from the component in the registry?

@me-no-dev
Copy link
Member

Thank you @magicarm22 , LGTM

@me-no-dev Could you please take a look? Are there any files that should be excluded from the component in the registry?

You actually do not need a large portion of the files. For example the tools folder which includes all headers and prebuilt libs for all chip (500MB+). We can skip the majority of files in the root as well. I will check, but you really only need CMakeLists.txt, core and variants folders.

@magicarm22 magicarm22 force-pushed the feature/idf_component branch from 6c0e561 to 4242628 Compare January 31, 2022 10:32
@magicarm22 magicarm22 force-pushed the feature/idf_component branch from 4242628 to 861fd48 Compare January 31, 2022 14:06
@VojtechBartoska VojtechBartoska linked an issue Jan 31, 2022 that may be closed by this pull request
@VojtechBartoska VojtechBartoska added this to the 2.0.3 milestone Jan 31, 2022
@VojtechBartoska VojtechBartoska removed this from the 2.0.3 milestone Jan 31, 2022
@magicarm22 magicarm22 force-pushed the feature/idf_component branch from 861fd48 to d6780d4 Compare February 1, 2022 15:12
@magicarm22
Copy link
Contributor Author

Thank you @magicarm22 , LGTM
@me-no-dev Could you please take a look? Are there any files that should be excluded from the component in the registry?

You actually do not need a large portion of the files. For example the tools folder which includes all headers and prebuilt libs for all chip (500MB+). We can skip the majority of files in the root as well. I will check, but you really only need CMakeLists.txt, core and variants folders.

Fixed using include and exclude blocks in the idf-component.yml file.

@me-no-dev me-no-dev merged commit 1046f59 into espressif:master Feb 3, 2022
@me-no-dev
Copy link
Member

Merged @magicarm22 and @kumekay :)

@grongor
Copy link

grongor commented Apr 17, 2022

Hi! I was just looking for this component and I've seen that this new CI job was never run yet.

First, I think there is an error that the job is only run on tags with v* prefix, but all the tags in this repository don't have this prefix (see https://github.com/espressif/arduino-esp32/blob/master/.github/workflows/upload-idf-component.yml#L5).

Secondly: would you mind running the job manually for at least the latest (and preferably stable) tags, so that I can pull the component using the registry?

Thanks!

@me-no-dev
Copy link
Member

@grongor we will release the next "stable" very soon and it will be in the component manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Publish arduino-esp32 component in idf-component-manager
8 participants