Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes errors and typos in the Arduino component for the esp-idf framework #6474

Closed
wants to merge 2 commits into from
Closed

Conversation

andreaz98
Copy link

@andreaz98 andreaz98 commented Mar 23, 2022

Summary

This PR fixes typos and fatal errors caused by either typos or missing files while building a generic ESP32 project that uses the Arduino Component.

The affected files are in the path arduino/cores/esp32 and arduino/libraries/WiFi/src

Impact

This PR fixes errors and typos in the esp-idf framework and its Arduino component allowing you to build not without warnings.

Related links

As of today, 23rd March 2022, Platformio uses esp-idf v3.x that clashes with the version used by the Arduino component v4.x. To solve the previous problem you will need to modify platformio.ini accordingly to the following pull request platformio/platform-espressif32#711

Open Problem

I have not found yet anything to fix some problems that arise from arduino/cores/esp32/wiring_digital.c. I wrote a arduino/cores/esp32/wiring_digital.h but I have not figured out how to fix the various problems.

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2022

CLA assistant check
All committers have signed the CLA.

@mrengineer7777
Copy link
Collaborator

I disagree with this modification of arduino-esp32.

Switching from <> to "" has to do with pathfinding. "" does a deeper search. Fine for your project but let's not modify the core.

I do see you made a modification to WiFiSTA.cpp. Can you tell us more about that?

    esp_wpa2_config_t config = WPA2_CONFIG_INIT_DEFAULT();
    esp_wifi_sta_wpa2_ent_enable(&config); //set config settings to enable function

I'm guessing you are targeting framework = idf, arduino.
https://espressif-docs.readthedocs-hosted.com/projects/arduino-esp32/en/latest/esp-idf_component.html#arduino-as-an-esp-idf-component)Arduino as an ESP-IDF component
I tried that path for a month. Then I switched to framework=idf with modified Arduino libraries for several months. While interesting it was also horribly painful. It's just not a great solution at this time.

#5819

@Jason2866
Copy link
Collaborator

I see no warning nor errors which requires this changes.
Compiling actual Arduino as component with actual IDF44 is working.
Even arduino, idf is no problem. See my CI example builds from here with latest Arduino (branch S3) and latest IDF44

@me-no-dev
Copy link
Member

we no longer support ESP-IDF before 4.4. IDF 3.3 support is in release/v1.0 branch :)

@me-no-dev me-no-dev closed this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants