Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CameraWebServer example fix #6993

Merged
merged 4 commits into from
Jul 18, 2022
Merged

CameraWebServer example fix #6993

merged 4 commits into from
Jul 18, 2022

Conversation

PilnyTomas
Copy link
Contributor

@PilnyTomas PilnyTomas commented Jul 15, 2022 •
edited
Loading

Description of Change

Fixed error appearing on verbose core debug level
Fixed warnings (missing initializers)

Tests scenarios

@P-R-O-C-H-Y tested on ESP32S3-EYE

Related links

no related issue

@PilnyTomas PilnyTomas self-assigned this Jul 15, 2022
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on EPS32S3-eye.
No compilation errors/warnings.
Example working :)
We can merge 👍

@PilnyTomas PilnyTomas changed the title WIP; Web cam fix Web cam fix Jul 15, 2022
@VojtechBartoska VojtechBartoska changed the title Web cam fix CameraWebServer example fix Jul 15, 2022
@VojtechBartoska VojtechBartoska added the Type: Example Issue is related to specific example. label Jul 15, 2022
@VojtechBartoska
Copy link
Collaborator

Let's wait for 2nd review from @SuGlider.

SuGlider
SuGlider approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @PilnyTomas!

@SuGlider SuGlider added this to the 2.0.5 milestone Jul 15, 2022
@SuGlider SuGlider mentioned this pull request Jul 16, 2022
Closed
1 task
@VojtechBartoska VojtechBartoska merged commit 53a097b into espressif:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@SuGlider SuGlider SuGlider approved these changes

Assignees

@PilnyTomas PilnyTomas

Labels
Type: Example Issue is related to specific example.
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@PilnyTomas @VojtechBartoska @SuGlider @P-R-O-C-H-Y