Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Cookie Case Sensitivity #7112

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Fixes Cookie Case Sensitivity #7112

merged 4 commits into from
Aug 16, 2022

Conversation

SuGlider
Copy link
Collaborator

Description of Change

Cookie Names and Value are case sensitive, but attibutes such as "Expires", "Max-Age", "Domain", "Path", "Secure", "HttpOnly" must be case insensitively matched. This PR fixes it in HTTPClient::setCookie(String date, String headerValue) function.

Tests scenarios

ESP32

Related links

Fixes #7076

@SuGlider SuGlider added this to the 2.0.5 milestone Aug 10, 2022
@SuGlider SuGlider self-assigned this Aug 10, 2022
@SuGlider SuGlider mentioned this pull request Aug 10, 2022
Closed
1 task
@SuGlider SuGlider added the Area: BT&Wifi BT & Wifi related issues label Aug 10, 2022
fvaryu added a commit to fvaryu/arduino-esp32 that referenced this pull request Aug 16, 2022
@fvaryu
Cookie(set-cookie) Value are case sensitive, fix espressif#1554 HTTPC…
53846b8 
…linet::setCookie() headerValue.toLowCase(). (espressif#7112)(espressif#7076)
@fvaryu fvaryu mentioned this pull request Aug 16, 2022
Closed
@P-R-O-C-H-Y P-R-O-C-H-Y merged commit fe1d9e0 into master Aug 16, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y deleted the SuGlider-patch-3 branch August 16, 2022 10:07
earlephilhower added a commit to earlephilhower/arduino-pico that referenced this pull request May 30, 2024
@earlephilhower
Add Cookies to HTTPClient
88b26ff 
From:
espressif/arduino-esp32#6216
espressif/arduino-esp32#6280
espressif/arduino-esp32#7112
@earlephilhower earlephilhower mentioned this pull request May 30, 2024
Merged
earlephilhower added a commit to earlephilhower/arduino-pico that referenced this pull request May 30, 2024
@earlephilhower
Add Cookies to HTTPClient
6c94651 
From:
espressif/arduino-esp32#6216
espressif/arduino-esp32#6280
espressif/arduino-esp32#7112
earlephilhower added a commit to earlephilhower/arduino-pico that referenced this pull request May 30, 2024
@earlephilhower
Add Cookies to HTTPClient (#2186)
0a2b616 
From:
espressif/arduino-esp32#6216
espressif/arduino-esp32#6280
espressif/arduino-esp32#7112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@PilnyTomas PilnyTomas PilnyTomas approved these changes

Assignees

@SuGlider SuGlider

Labels
Area: BT&Wifi BT & Wifi related issues
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.

HttpClient.cpp#setCookie()
3 participants
@SuGlider @PilnyTomas @P-R-O-C-H-Y