Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add ESP32S3 to libraries support list #7415

Merged
merged 3 commits into from
Nov 3, 2022
Merged

[DOCS] Add ESP32S3 to libraries support list #7415

merged 3 commits into from
Nov 3, 2022

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Oct 31, 2022 •
edited
Loading

Description of Change

Added ESP32S3 to libraries support list.
Added SDMMC to the list.

Tests scenarios

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: Documentation Issue pertains to Documentation of Arduino ESP32 label Oct 31, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Oct 31, 2022
@P-R-O-C-H-Y
Copy link
Member Author

@pedrominatel As you can see I have added the S3 to the table, but when is "Not Supported" in cell it it doesn't look good. Can we do something with that? :) Thanks for tips.

pedrominatel
pedrominatel approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuGlider SuGlider self-requested a review November 2, 2022 20:01
SuGlider
SuGlider reviewed Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please just check the I2S note that I left.

docs/source/libraries.rst Outdated Show resolved Hide resolved
@P-R-O-C-H-Y P-R-O-C-H-Y merged commit bf26503 into espressif:master Nov 3, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y deleted the Docs-s3-support branch November 3, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrominatel pedrominatel pedrominatel approved these changes

@VojtechBartoska VojtechBartoska Awaiting requested review from VojtechBartoska

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

@SuGlider SuGlider Awaiting requested review from SuGlider

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P-R-O-C-H-Y @pedrominatel @SuGlider