Skip to content

Conversation

lmarzen
Copy link
Contributor

@lmarzen lmarzen commented Feb 11, 2023

Description of Change

This PR adds support for the DFRobot FireBeetle 2 ESP32-E board. (https://wiki.dfrobot.com/FireBeetle_Board_ESP32_E_SKU_DFR0654) No impact to other boards.

Tests scenarios

I have tested my Pull Request on master with dfrobot firebeetle 2 esp32-e board. Successfully uploads sketches.

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2023

CLA assistant check
All committers have signed the CLA.

@lmarzen
Copy link
Contributor Author

lmarzen commented Feb 11, 2023

...squashed commits it one

@ejagombar
Copy link

Hi @lmarzen

Not sure if I should be asking here, but I just wanted to know, how did you know what to add to the boards.txt file? I understand the JSON file but didnt get this one.
Did you modify an existing board or write it from scratch?

Thanks very much for your help.

@lmarzen
Copy link
Contributor Author

lmarzen commented Feb 13, 2023

@ejagombar, you are right on. I modified other recently added firebeetle boards, and additionally, I read the wiki for the board which is where I found that DFRobot released an older version of arduino-esp32 that was significantly trimmed down, but it contained the supported menu options. So cross referencing everything, I was able to put together all the parameters together

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Feb 15, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Feb 15, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Feb 15, 2023
@me-no-dev me-no-dev merged commit 12ed792 into espressif:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants