Skip to content

2.0.10 escaping fix #8433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

pillo79
Copy link
Contributor

@pillo79 pillo79 commented Jul 19, 2023

Description of Change

Fix escaping issues on 2.0.10 (Windows path and IDE 1.x).

Tests scenarios

Tested on clean Windows 11 box, Arduino IDE 2.1.1, username with spaces, 2.0.10. The issue is present and is fixed by these commits.
Includes patch by @pennam fixing #8424 for IDE 1.8.x.

Related links

Closes #8424 and fixes Windows path issues reported in Arduino forums e.g. here and here

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2023

CLA assistant check
All committers have signed the CLA.

@pillo79 pillo79 force-pushed the 2.0.10-escaping-fix branch from c07a5f6 to 3341971 Compare July 19, 2023 22:57
@me-no-dev me-no-dev merged commit 4c27949 into espressif:release/v2.x Jul 20, 2023
@VojtechBartoska
Copy link
Contributor

closes also #8430

@VojtechBartoska VojtechBartoska added this to the 2.0.11 milestone Jul 20, 2023
me-no-dev pushed a commit that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants