Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplemented flush in WiFiClient #8541

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

PilnyTomas
Copy link
Contributor

@PilnyTomas PilnyTomas commented Aug 18, 2023

The WiFiClient doesn't seem responsible for the actual reading, yet the function WiFiClient::flush was calling recv().
This resulted in errors.
I have reimplemented the WiFiClient::flush functionality into the WiFiClientRxBuffer and the WiFiClient::flush simply calls that: _rxBuffer->flush();
Solves #6129

@VojtechBartoska VojtechBartoska added this to the 2.0.12 milestone Aug 21, 2023
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tested SDWebServer example and no issue with new flush implementation.
Seems to be well tested by the community as-well.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Aug 24, 2023
@sudheeshsmadhav
Copy link

the issue is not solved yet. Even after accepting these changes, Still the esp log prints [1522598][E][WiFiClient.cpp:430] write(): fail on fd 48, errno: 11, "No more processes"

#6129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

6 participants