Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[I2S][SR] Add new I2S library and Sound Recognition support #8714

Merged
merged 19 commits into from
Oct 18, 2023
Merged

[I2S][SR] Add new I2S library and Sound Recognition support #8714

merged 19 commits into from
Oct 18, 2023

Conversation

me-no-dev
Copy link
Member

Redo of: #8617

@VojtechBartoska VojtechBartoska added the Area: Peripherals API Relates to peripheral's APIs. label Oct 5, 2023
@me-no-dev me-no-dev marked this pull request as draft October 6, 2023 10:51
me-no-dev
me-no-dev commented Oct 16, 2023
View reviewed changes
libraries/ESP_I2S/src/ESP_I2S.cpp
if(_rx_din3 >= 0){
if(!perimanSetPinBus(_rx_din3, ESP32_BUS_TYPE_I2S_PDM, (void *)(this))){ goto err; }
}
break;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of having 4 cases one after another, have 4 separate private methods to init each type.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. A lot cleaner code now :)

@me-no-dev
Copy link
Member Author

me-no-dev commented Oct 16, 2023 •
edited
Loading

Don't forget to fix the examples :) Also add some for the different modes.

@me-no-dev me-no-dev marked this pull request as ready for review October 18, 2023 08:58
@me-no-dev me-no-dev merged commit 601efed into master Oct 18, 2023
36 checks passed
@me-no-dev me-no-dev deleted the feature/i2s_sr branch October 18, 2023 09:05
This was referenced Oct 18, 2023
Closed
Closed
@VojtechBartoska VojtechBartoska mentioned this pull request Dec 13, 2023
Closed
1 task
This was referenced Feb 20, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y left review comments

Assignees

@me-no-dev me-no-dev

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Peripherals API Relates to peripheral's APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@me-no-dev @P-R-O-C-H-Y @VojtechBartoska