Skip to content

Remove unsupported DOUT and QOUT options #8805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2023
Merged

Remove unsupported DOUT and QOUT options #8805

merged 2 commits into from
Oct 25, 2023

Conversation

@lucasssvaz
Copy link
Member

Description of Change

This PR aims to remove the unsupported DOUT and QOUT boot options that are breaking the CI.

Tests scenarios

Tested with Arduino IDE 1.8.19

@lucasssvaz lucasssvaz added Type: Chip support Concerns support for a specific SoC. IDE: Arduino IDE Issue relates to Arduino IDE Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. labels Oct 25, 2023
@lucasssvaz lucasssvaz self-assigned this Oct 25, 2023
@lucasssvaz lucasssvaz added the hil_test Run Hardware Tests label Oct 25, 2023
@lucasssvaz lucasssvaz changed the title boards.txt: Remove unsupported DOUT and QOUT options Remove unsupported DOUT and QOUT options Oct 25, 2023
@lucasssvaz lucasssvaz added Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure. and removed IDE: Arduino IDE Issue relates to Arduino IDE labels Oct 25, 2023
@lucasssvaz lucasssvaz mentioned this pull request Oct 25, 2023
Merged
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! CI Tests passed

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Oct 25, 2023
@me-no-dev me-no-dev merged commit 78ac143 into espressif:master Oct 25, 2023
@lucasssvaz lucasssvaz deleted the bugfix/boot_options branch March 19, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@lucasssvaz lucasssvaz

Labels

hil_test Run Hardware Tests Status: Pending Merge Pull Request is ready to be merged Type: Chip support Concerns support for a specific SoC. Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure. Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucasssvaz @P-R-O-C-H-Y @me-no-dev