-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zigbee examples #9024
Add Zigbee examples #9024
Conversation
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have mixed feeling about it. It is an IDF code translated to compile in Arduino IDE.
I think that a broader work for creating comprehensive Arduino Classes would be more valuable.
This could be part of an example "in our own GH", but I'm sure this should be in the ESP32 Arduino repository.
libraries/ESP32/examples/Zigbee/Zigbee_Light_Bulb/Zigbee_Light_Bulb.ino
Outdated
Show resolved
Hide resolved
libraries/ESP32/examples/Zigbee/Zigbee_Light_Switch/Zigbee_Light_Switch.ino
Show resolved
Hide resolved
libraries/ESP32/examples/Zigbee/Zigbee_Light_Switch/Zigbee_Light_Switch.ino
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @SuGlider. Just like the BLEMesh examples were added to gist, I think should be added there and linked in the docs until we have a proper lib.
@lucasssvaz @SuGlider Lets discuss it on todays meeting :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed in the meeting, LGTM. Just need to fix the CI.
Seems that we can close #8807 when this will be merged. |
Added skip files for all SoCs to skip those examples in the Github CI, as we are not able now to specify FQNB separately for each example. |
libraries/ESP32/examples/Zigbee/Zigbee_Light_Switch/Zigbee_Light_Switch.ino
Outdated
Show resolved
Hide resolved
} | ||
|
||
// Start Zigbee task | ||
xTaskCreate(esp_zb_task, "Zigbee_main", 4096, NULL, 5, NULL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not run the main task in loop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or the button task?
libraries/ESP32/examples/Zigbee/Zigbee_Light_Bulb/Zigbee_Light_Bulb.ino
Outdated
Show resolved
Hide resolved
neopixelWrite(LED_PIN,0,0,0); | ||
|
||
//Start Zigbee task | ||
xTaskCreate(esp_zb_task, "Zigbee_main", 4096, NULL, 5, NULL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this task looks like something that you can just execute here.
@P-R-O-C-H-Y ping |
@me-no-dev Is it ok now?
|
I've seen examples of Zigbee devices like Zigbee_Light_Bulb and Zigbee_Light_Switch. Could you provide an example for a sensor, such as one for temperature and humidity? This would make the entire Zigbee architecture and usage clearer, allowing more people to get involved in this field. |
Description of Change
This PR adds 2 examples to demonstrate usage of Zigbee stack:
Supported SoCs are ESP32C6 and ESP32-H2.
Tests scenarios
Tested locally by flashing Zigbee_Light_Bulb to ESP32-C6 DevKitM and Zigbee_Light_Switch to ESP32-H2 DevKitM.
CI is skipping the examples for now, as we cannot specify the FQBN.
Related links
Closes #8807
Blocked by #9025 (new GPIO Interrupt enable/disable methods)-> Merged