Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example(esp32): Set the maximum value of AnalogRead to 4095 #9114

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

tanakamasayuki
Copy link
Contributor

The 12-bit MAX is 4095, not 4096.

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

Description of Change

Fixed an incorrect comment.

Tests scenarios

Confirm that values from 0 to 4095 can be obtained.

Copy link
Contributor

github-actions bot commented Jan 16, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello tanakamasayuki, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2216c09

@P-R-O-C-H-Y P-R-O-C-H-Y added Type: Example Issue is related to specific example. Status: Pending Merge Pull Request is ready to be merged labels Jan 16, 2024
@me-no-dev me-no-dev merged commit 90bef0b into espressif:master Jan 16, 2024
49 checks passed
@VojtechBartoska VojtechBartoska changed the title fix(esp32): Set the maximum value of AnalogRead to 4095 fix example(esp32): Set the maximum value of AnalogRead to 4095 Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: Example Issue is related to specific example.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants