Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add board support for Nologo ESP32C3 Super Mini #9174

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

imyelo
Copy link
Contributor

@imyelo imyelo commented Jan 25, 2024

Description of Change

Add board support for Nologo ESP32C3 Super Mini

Tests scenarios

I have tested my pr on this board. Verified by compiling and uploading using PlatformIO, cherry-picking the changes onto the v2.0.11 branch.

Related links

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Jan 25, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello imyelo, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2517802

@imyelo imyelo force-pushed the boards/nologo_esp32c3_super_mini branch from 830adc3 to 3b6acd6 Compare January 27, 2024 11:45
@imyelo imyelo marked this pull request as ready for review January 27, 2024 12:44
@imyelo imyelo force-pushed the boards/nologo_esp32c3_super_mini branch from 3b6acd6 to 2517802 Compare January 29, 2024 07:07
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Jan 29, 2024
@VojtechBartoska VojtechBartoska added this to the 3.0.0-RC1 milestone Jan 30, 2024
@me-no-dev me-no-dev merged commit 8eaa893 into espressif:master Jan 31, 2024
39 checks passed
@imyelo imyelo deleted the boards/nologo_esp32c3_super_mini branch January 31, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
Development

Successfully merging this pull request may close these issues.

5 participants