-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: New Class MacAddress similar to IPAddress #9304
Feature: New Class MacAddress similar to IPAddress #9304
Conversation
In the same style as class IPAddress. Based on Apache License.
Added a few changes to make it closer to IPAddress Class implementation.
Makes it closer to IPAddress Class implementation
Moved implementation details .h->.cpp. Added bounds checking on index operators. Added constructor to MacAddress8 to match MacAddress.
Chars must be uppercase to match toString() and pass test
…ture/mac-adress-refactor
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…O-C-H-Y/arduino-esp32 into feature/mac-adress-refactor
@mrengineer7777 will you chime in to say if you are OK with this PR? |
@P-R-O-C-H-Y Could you add a simple example sketch ? (A very basic one is enough IMO) |
Description of Change
This adds new class
MacAddress
that allows for better handling of MAC and BSSID addresses.MacAddress also support 8-byte EUI-64 as noted in
esp_mac.h
.Changes have been done on top of @mrengineer7777 PR #6667. Thanks David!
Tests scenarios
Tested by running slightly modified test sketch by @mrengineer7777.
https://gist.github.com/P-R-O-C-H-Y/ab6b2443fc57bc12ec424f89493b9022
Related links
Closes #6658