HardwareSerial:begin() changes RTS and CTS pins preventing detaching those pins #9353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Begin() may "undo" a setpins() that has set RTS and/or CTS pin.
As consequence, RTS and CTS won't be detached with end().
This pins are only changed by using setPins() passing RTS and CTS.
setpins() can be called after or before begin()
when called before, begin() shall not change those pins.
This PR fixes it.
Tests scenarios
Tested with ESP32 just checking logs.
Related links
This changes has been backported to 2.0.15 by #9176