Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variant for Waveshare ESP32-S3-Touch-LCD-1.28 #9386

Merged
merged 10 commits into from
Mar 26, 2024

Conversation

deisterhold
Copy link
Contributor

Description of Change

Adding variant for Waveshare ESP32-S3-Touch-LCD-1.28 board containing MCU, LCD, and IMU.

Tests scenarios

Untested, pin definition is based on information in Waveshare wiki.

Related links

Link to board wiki: https://www.waveshare.com/wiki/ESP32-S3-Touch-LCD-1.28

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Mar 16, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat(esp32): Add variant for Waveshare ESP32 board":
    • probably contains Jira ticket reference (LCD-1). Please remove Jira tickets from commit messages.

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 10 commits (simplifying branch history).

👋 Hello deisterhold, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 24d0cf6

deisterhold added a commit to deisterhold/platform-espressif32 that referenced this pull request Mar 16, 2024
@me-no-dev
Copy link
Member

It's missing the board definitions in boards.txt

@deisterhold
Copy link
Contributor Author

Updated boards.txt

@P-R-O-C-H-Y P-R-O-C-H-Y removed the Resolution: Awaiting response Waiting for response of author label Mar 19, 2024
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just one small suggestion :)

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI Boards test is failing, due to missing USB stuff in boards.txt
I have added a suggestions what needs to be added/changed.

Have you tested if compilation works for you in the Arduino IDE?
Without those changes it fails. PTAL and after adding those changes test the board if you have one :) Thanks

@P-R-O-C-H-Y P-R-O-C-H-Y added the Resolution: Awaiting response Waiting for response of author label Mar 19, 2024
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now :)
@deisterhold There are some conflicts in boards.txt file, please fix them so we can merge.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels Mar 22, 2024
@me-no-dev me-no-dev merged commit 75f7b33 into espressif:master Mar 26, 2024
39 checks passed
@deisterhold deisterhold deleted the patch-1 branch March 26, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants