-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variant for Waveshare ESP32-S3-Touch-LCD-1.28 #9386
Conversation
👋 Hello deisterhold, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Variant is based on this PR espressif/arduino-esp32#9386
It's missing the board definitions in |
Updated boards.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just one small suggestion :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI Boards test is failing, due to missing USB stuff in boards.txt
I have added a suggestions what needs to be added/changed.
Have you tested if compilation works for you in the Arduino IDE?
Without those changes it fails. PTAL and after adding those changes test the board if you have one :) Thanks
fix(esp32): Specify PSRAM type and remove unused board options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now :)
@deisterhold There are some conflicts in boards.txt file, please fix them so we can merge.
Description of Change
Adding variant for Waveshare ESP32-S3-Touch-LCD-1.28 board containing MCU, LCD, and IMU.
Tests scenarios
Untested, pin definition is based on information in Waveshare wiki.
Related links
Link to board wiki: https://www.waveshare.com/wiki/ESP32-S3-Touch-LCD-1.28