Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkClient - don't stop() in destroy #9543

Closed
wants to merge 1 commit into from
Closed

NetworkClient - don't stop() in destroy #9543

wants to merge 1 commit into from

Conversation

JAndrassy
Copy link
Contributor

@JAndrassy JAndrassy commented Apr 20, 2024 •
edited
Loading

Destroy of a NetworkClient instance should not close the TCP connection unless it is the last copy handling that connection. Thanks to shared_ptr NetworkClientSocketHandle instance closes the connection as it is destroyed when the last copy of NetworkClient for that connection is destroyed.

@JAndrassy
fix: NetworkClient - don't stop() in destroy
4b8a985 
shared_ptr NetworkClientSocketHandle destroy closes the connection
when the last copy of WiFiClient is destroyed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 20, 2024 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello JAndrassy, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4b8a985

@JAndrassy JAndrassy mentioned this pull request Apr 20, 2024
Merged
@JAndrassy JAndrassy changed the title fix: NetworkClient - don't stop() in destroy NetworkClient - don't stop() in destroy Apr 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3💚 -800.000.00000.000.00
ESP32S2💚 -16⚠️ +40.000.00000.000.00
ESP32C3💚 -800.000.00000.000.00
ESP32C6💚 -800.000.00000.000.00
ESP32H2💚 -600.000.00000.000.00
ESP32💚 -800.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ArduinoOTA/examples/BasicOTA💚 -80💚 -80💚 -40💚 -40--💚 -80
AsyncUDP/examples/AsyncUDPClient00000000--00
AsyncUDP/examples/AsyncUDPMulticastServer00000000--00
AsyncUDP/examples/AsyncUDPServer00000000--00
BLE/examples/BLE5_extended_scan00--000000--
BLE/examples/BLE5_multi_advertising00--000000--
BLE/examples/BLE5_periodic_advertising00--000000--
BLE/examples/BLE5_periodic_sync00--000000--
BLE/examples/Beacon_Scanner00--00000000
BLE/examples/Client00--00000000
BLE/examples/EddystoneTLM_Beacon00--0000--00
BLE/examples/EddystoneURL_Beacon00--0000--00
BLE/examples/Notify00--00000000
BLE/examples/Scan00--00000000
BLE/examples/Server00--00000000
BLE/examples/Server_multiconnect00--00000000
BLE/examples/UART00--00000000
BLE/examples/Write00--00000000
BLE/examples/iBeacon00--00000000
DNSServer/examples/CaptivePortal💚 -80💚 -40💚 -40💚 -40--💚 -80
EEPROM/examples/eeprom_class000000000000
EEPROM/examples/eeprom_extra000000000000
EEPROM/examples/eeprom_write000000000000
ESP32/examples/AnalogOut/LEDCFade000000000000
ESP32/examples/AnalogOut/LEDCSoftwareFade000000000000
ESP32/examples/AnalogOut/SigmaDelta000000000000
ESP32/examples/AnalogOut/ledcFrequency000000000000
ESP32/examples/AnalogOut/ledcWrite_RGB000000000000
ESP32/examples/AnalogRead000000000000
ESP32/examples/AnalogReadContinuous000000000000
ESP32/examples/ArduinoStackSize000000000000
ESP32/examples/CI/CIBoardsTest000000000000
ESP32/examples/Camera/CameraWebServer0000------00
ESP32/examples/ChipID/GetChipID000000000000
ESP32/examples/DeepSleep/ExternalWakeUp0000------00
ESP32/examples/DeepSleep/TimerWakeUp00000000--00
ESP32/examples/DeepSleep/TouchWakeUp0000------00
ESP32/examples/FreeRTOS/BasicMultiThreading000000000000
ESP32/examples/FreeRTOS/Mutex000000000000
ESP32/examples/FreeRTOS/Queue000000000000
ESP32/examples/FreeRTOS/Semaphore000000000000
ESP32/examples/GPIO/BlinkRGB000000000000
ESP32/examples/GPIO/FunctionalInterrupt000000000000
ESP32/examples/GPIO/FunctionalInterruptStruct000000000000
ESP32/examples/GPIO/GPIOInterrupt000000000000
ESP32/examples/HWCDC_Events00--000000--
ESP32/examples/MacAddress/GetMacAddress000000000000
ESP32/examples/RMT/RMTCallback000000000000
ESP32/examples/RMT/RMTLoopback000000000000
ESP32/examples/RMT/RMTReadXJT000000000000
ESP32/examples/RMT/RMTWriteNeoPixel000000000000
ESP32/examples/RMT/RMT_CPUFreq_Test000000000000
ESP32/examples/RMT/RMT_EndOfTransmissionState000000000000
ESP32/examples/RMT/RMT_LED_Blink000000000000
ESP32/examples/ResetReason/ResetReason000000000000
ESP32/examples/ResetReason/ResetReason2000000000000
ESP32/examples/Serial/BaudRateDetect_Demo000000000000
ESP32/examples/Serial/OnReceiveError_BREAK_Demo000000000000
ESP32/examples/Serial/OnReceive_Demo000000000000
ESP32/examples/Serial/RS485_Echo_Demo000000000000
ESP32/examples/Serial/RxFIFOFull_Demo000000000000
ESP32/examples/Serial/RxTimeout_Demo000000000000
ESP32/examples/Serial/Serial_All_CPU_Freqs000000000000
ESP32/examples/Serial/Serial_STD_Func_OnReceive000000000000
ESP32/examples/Serial/onReceiveExample000000000000
ESP32/examples/TWAI/TWAIreceive000000000000
ESP32/examples/TWAI/TWAItransmit000000000000
ESP32/examples/Template/ExampleTemplate000000000000
ESP32/examples/Time/SimpleTime00000000--00
ESP32/examples/Timer/RepeatTimer000000000000
ESP32/examples/Timer/WatchdogTimer000000000000
ESP32/examples/Touch/TouchButtonV20000--------
ESP32/examples/Touch/TouchInterrupt0000------00
ESP32/examples/Touch/TouchRead0000------00
ESP32/examples/Utilities/HEXBuilder000000000000
ESP32/examples/Utilities/MD5Builder000000000000
ESP32/examples/Utilities/SHA1Builder000000000000
ESP_I2S/examples/ES8388_loopback000000000000
ESP_I2S/examples/Record_to_WAV00--------00
ESP_I2S/examples/Simple_tone000000000000
ESP_NOW/examples/ESP_NOW_Broadcast_Master00000000--00
ESP_NOW/examples/ESP_NOW_Broadcast_Slave00000000--00
ESP_NOW/examples/ESP_NOW_Network00000000--00
ESP_NOW/examples/ESP_NOW_Serial00000000--00
ESP_SR/examples/Basic00----------
ESPmDNS/examples/mDNS-SD_Extended00000000--00
ESPmDNS/examples/mDNS_Web_Server💚 -40💚 -40💚 -40💚 -40--💚 -80
Ethernet/examples/ETH_W5500_Arduino_SPI💚 -40💚 -40💚 -40💚 -40💚 -40💚 -40
Ethernet/examples/ETH_W5500_IDF_SPI💚 -40💚 -40💚 -40💚 -40💚 -60💚 -40
FFat/examples/FFat_Test000000000000
FFat/examples/FFat_time00000000--00
HTTPClient/examples/Authorization💚 -40💚 -40💚 -40💚 -60--💚 -80
HTTPClient/examples/BasicHttpClient💚 -40💚 -40💚 -40💚 -60--💚 -80
HTTPClient/examples/BasicHttpsClient💚 -80💚 -120💚 -60💚 -60--💚 -80
HTTPClient/examples/HTTPClientEnterprise💚 -80💚 -40💚 -60💚 -60--💚 -80
HTTPClient/examples/ReuseConnection💚 -80💚 -40💚 -40💚 -40--💚 -80
HTTPClient/examples/StreamHttpClient💚 -80💚 -40💚 -40💚 -40--💚 -80
HTTPUpdate/examples/httpUpdate💚 -80💚 -40💚 -40💚 -40--💚 -80
HTTPUpdate/examples/httpUpdateSPIFFS💚 -80💚 -40💚 -40💚 -40--💚 -80
HTTPUpdate/examples/httpUpdateSecure💚 -80💚 -40💚 -60💚 -60--💚 -80
HTTPUpdateServer/examples/WebUpdater💚 -80💚 -80💚 -40💚 -40--💚 -80
Insights/examples/DiagnosticsSmokeTest000000----00
Insights/examples/MinimalDiagnostics000000----00
LittleFS/examples/LITTLEFS_test000000000000
LittleFS/examples/LITTLEFS_time00000000--00
NetBIOS/examples/ESP_NBNST00000000--00
NetworkClientSecure/examples/WiFiClientInsecure💚 -80💚 -80💚 -40💚 -60--💚 -80
NetworkClientSecure/examples/WiFiClientPSK💚 -80💚 -40💚 -80💚 -80--💚 -80
NetworkClientSecure/examples/WiFiClientSecure💚 -80💚 -80💚 -40💚 -40--💚 -80
NetworkClientSecure/examples/WiFiClientSecureEnterprise💚 -80💚 -40💚 -40💚 -40--💚 -80
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade💚 -80💚 -40💚 -60💚 -60--💚 -80
NetworkClientSecure/examples/WiFiClientShowPeerCredentials00💚 -40💚 -60💚 -40--💚 -80
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse💚 -80💚 -40💚 -40💚 -40--💚 -80
PPP/examples/PPP_Basic💚 -40💚 -40💚 -40💚 -40💚 -40💚 -40
Preferences/examples/Prefs2Struct000000000000
Preferences/examples/StartCounter000000000000
RainMaker/examples/RMakerCustom000000----00
RainMaker/examples/RMakerCustomAirCooler000000----00
RainMaker/examples/RMakerSonoffDualR3000000----00
RainMaker/examples/RMakerSwitch000000----00
SD/examples/SD_Test000000000000
SD/examples/SD_time00000000--00
SD_MMC/examples/SDMMC_Test00--------00
SD_MMC/examples/SDMMC_time00--------00
SPI/examples/SPI_Multiple_Buses0000------00
SPIFFS/examples/SPIFFS_Test000000000000
SPIFFS/examples/SPIFFS_time00000000--00
SimpleBLE/examples/SimpleBleDevice00----000000
TFLiteMicro/examples/hello_world000000000000
TFLiteMicro/examples/micro_speech000000000000
Ticker/examples/Blinker000000000000
Ticker/examples/TickerBasic000000000000
Ticker/examples/TickerParameter000000000000
USB/examples/CompositeDevice0000--------
USB/examples/ConsumerControl0000--------
USB/examples/CustomHIDDevice0000--------
USB/examples/FirmwareMSC0000--------
USB/examples/Gamepad0000--------
USB/examples/HIDVendor0000--------
USB/examples/Keyboard/KeyboardLogout0000--------
USB/examples/Keyboard/KeyboardMessage0000--------
USB/examples/Keyboard/KeyboardReprogram0000--------
USB/examples/Keyboard/KeyboardSerial0000--------
USB/examples/KeyboardAndMouseControl0000--------
USB/examples/MIDI/MidiController0000--------
USB/examples/MIDI/MidiInterface0000--------
USB/examples/MIDI/MidiMusicBox0000--------
USB/examples/MIDI/ReceiveMidi0000--------
USB/examples/Mouse/ButtonMouseControl0000--------
USB/examples/SystemControl0000--------
USB/examples/USBMSC0000--------
USB/examples/USBSerial0000--------
USB/examples/USBVendor0000--------
Update/examples/AWS_S3_OTA_Update💚 -80💚 -40💚 -40💚 -40--💚 -80
Update/examples/HTTPS_OTA_Update00000000--00
Update/examples/HTTP_Client_AES_OTA_Update💚 -80⚠️ +40💚 -60💚 -60--💚 -80
Update/examples/HTTP_Server_AES_OTA_Update💚 -80💚 -80💚 -60💚 -40--💚 -80
Update/examples/OTAWebUpdater💚 -80💚 -40💚 -40💚 -40--💚 -80
Update/examples/SD_Update000000000000
WebServer/examples/AdvancedWebServer💚 -80💚 -40💚 -40💚 -60--💚 -80
WebServer/examples/FSBrowser💚 -80💚 -40💚 -60💚 -60--💚 -80
WebServer/examples/HelloServer💚 -80💚 -40💚 -40💚 -40--💚 -80
WebServer/examples/HttpAdvancedAuth💚 -80💚 -40💚 -40💚 -40--💚 -80
WebServer/examples/HttpAuthCallback💚 -80💚 -40💚 -40💚 -40--💚 -80
WebServer/examples/HttpAuthCallbackInline💚 -80💚 -40💚 -40💚 -40--💚 -80
WebServer/examples/HttpBasicAuth💚 -80💚 -40💚 -40💚 -40--💚 -80
WebServer/examples/HttpBasicAuthSHA1💚 -80💚 -40💚 -60💚 -40--💚 -80
WebServer/examples/HttpBasicAuthSHA1orBearerToken💚 -80💚 -40💚 -40💚 -40--💚 -80
WebServer/examples/MultiHomedServers💚 -80💚 -40💚 -40💚 -40--💚 -80
WebServer/examples/PathArgServer💚 -80💚 -80💚 -60💚 -60--💚 -80
WebServer/examples/SDWebServer💚 -80💚 -40💚 -60💚 -60--💚 -80
WebServer/examples/SimpleAuthentification💚 -80💚 -40💚 -40💚 -40--💚 -80
WebServer/examples/UploadHugeFile💚 -80💚 -40💚 -60💚 -60--💚 -80
WebServer/examples/WebServer💚 -80💚 -40💚 -60💚 -60--💚 -80
WebServer/examples/WebUpdate💚 -80💚 -40💚 -40💚 -40--💚 -80
WiFi/examples/FTM/FTM_Initiator00000000--00
WiFi/examples/FTM/FTM_Responder00000000--00
WiFi/examples/SimpleWiFiServer💚 -80💚 -80💚 -40💚 -40--💚 -80
WiFi/examples/WPS00000000--00
WiFi/examples/WiFiAccessPoint💚 -80💚 -40💚 -40💚 -40--💚 -80
WiFi/examples/WiFiBlueToothSwitch00--0000--00
WiFi/examples/WiFiClient💚 -80💚 -160💚 -40💚 -40--💚 -80
WiFi/examples/WiFiClientBasic💚 -80💚 -40💚 -40💚 -40--💚 -80
WiFi/examples/WiFiClientConnect00000000--00
WiFi/examples/WiFiClientEnterprise💚 -80💚 -40💚 -40💚 -40--💚 -80
WiFi/examples/WiFiClientEvents00000000--00
WiFi/examples/WiFiClientStaticIP💚 -80💚 -40💚 -40💚 -60--💚 -80
WiFi/examples/WiFiIPv600000000--00
WiFi/examples/WiFiMulti00000000--00
WiFi/examples/WiFiMultiAdvanced💚 -80💚 -40💚 -40💚 -40--💚 -80
WiFi/examples/WiFiScan00000000--00
WiFi/examples/WiFiScanAsync00000000--00
WiFi/examples/WiFiScanDualAntenna00000000--00
WiFi/examples/WiFiSmartConfig00000000--00
WiFi/examples/WiFiTelnetToSerial💚 -80💚 -40💚 -40💚 -40--💚 -80
WiFi/examples/WiFiUDPClient00000000--00
WiFiProv/examples/WiFiProv00000000--00
Wire/examples/WireMaster000000000000
Wire/examples/WireScan000000000000
Wire/examples/WireSlave000000000000
BluetoothSerial/examples/DiscoverConnect----------00
BluetoothSerial/examples/GetLocalMAC----------00
BluetoothSerial/examples/SerialToSerialBT----------00
BluetoothSerial/examples/SerialToSerialBTM----------00
BluetoothSerial/examples/SerialToSerialBT_Legacy----------00
BluetoothSerial/examples/SerialToSerialBT_SSP----------00
BluetoothSerial/examples/bt_classic_device_discovery----------00
BluetoothSerial/examples/bt_remove_paired_devices----------00
ESP32/examples/DeepSleep/SmoothBlink_ULP_Code----------00
ESP32/examples/Touch/TouchButton----------00
Ethernet/examples/ETH_LAN8720----------💚 -40
Ethernet/examples/ETH_TLK110----------💚 -40

@JAndrassy JAndrassy closed this Apr 21, 2024
@JAndrassy JAndrassy deleted the ethernetclient_dont_stop_in_destroy branch April 21, 2024 04:53
@JAndrassy
Copy link
Contributor Author

sorry. it only makes sense as part of PR #9542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JAndrassy