Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hwcdc): Fixes HWCDC fw uploading #9660

Merged
merged 1 commit into from
May 22, 2024
Merged

feat(hwcdc): Fixes HWCDC fw uploading #9660

merged 1 commit into from
May 22, 2024

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented May 21, 2024

Description of Change

This PR is a backport of #9628

  • Fixes HW CDC uploading issue using the HWSerial/JTAG port.
  • Changes SOF detection from ISR to Timer routine instead
  • Uses correct logging functions in order to separate UART from USB CDC, always closing one or the other whenever one of them is selected using setDebugOutput(bool) method.
  • Fixes a warning about %ld versus %d in the HWCDC_Events.ino example.

Tests scenarios

Tested for ESP32-S3 and ESP32-C3 using the HWCDC_Events.ino example.
Tested also for ESP32-S3, ESP32-C3 and ESP32-S2 for chekcing that the log_XX() functions work correctly.

Related links

Fix #9646
Fix #9580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2 participants