fix: close pipes in gdb subprocess

espressif · Oct 31, 2024 · 51fdc71 · 51fdc71
1 parent f15a82c
commit 51fdc71
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/esp_coredump/corefile/gdb.py b/esp_coredump/corefile/gdb.py
@@ -5,6 +5,7 @@
 #
 
 import logging
+import os
 import re
 import time
 from subprocess import TimeoutExpired
@@ -40,6 +41,9 @@ def __del__(self):
         try:
             if self.p.gdb_process:
                 self.p.gdb_process.terminate()
+                if os.name != 'nt':
+                    # this is causing an Exception on Windows, but is required on UNIX systems
+                    self.p.gdb_process.communicate()  # Close pipes (STDIN, STDOUT, STDERR)
                 try:
                     self.p.gdb_process.wait(timeout=1)
                 except TimeoutExpired: