[clang support] Change pointer type to volatile in utils crash handler #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. delayed network status notification from slave to host in case of deep sleep
- Refactor LWIP port macros - Add UDP port configuration - Fix host power save handling - Improve SPI buffer management with DMA alignment checks - Update packet filtering during host sleep mode
- Implement optional workqueue for SPI handling - Replace semaphore-based approach - Optimize transaction queuing timing - Fix checksum calculation - Improve network queue management
- Add transaction timing measurements - Optimize SPI handler with CS deassertion semaphore - Implement better error handling in SPI write/read paths - Configure high-priority workqueue for improved
Fix the memory leak in async path
Fix the unwanted repeatative logs in hosted shell
Fix: Simplify connect_ap handling (removed event group)
…acked' structures in between host and slave 2. Fixed double free for RPC request memory 3. Host SPI: Add Flexibility at host to use Workqueue instead of semaphore solution 4. Slave SPI: Extra Debug logs for SPI 5. Added back esp_reset from host to slave
1. Fix SPI throughput issue when MCU is set in UDP 2. C5 5G header change 3. Clean up of code
- added `print_capabilities()` function to spi - added extra check for BT over UART in `process_capabilities()`
- changed BT SOC checks to include C5
- Simplified CLI Kconfig options - Prevent auto-connect with SSID in flash when a new SSID is requested
- Reuse feature_enable_disable sync call to get network split availabilty as response - User-facing debugs updated depending upon network split
- modified logic used to connect to AP when device is not yet provisioned - modified printout to indicate that we connected with static IP
1. Auto Network Setup - Auto configure network on host bootup 2. Network Split - Allow ESP ans host to run network, with same IP Also updated main README to let user know scenarios and how to choose NG/ FG/ MCU solutions
1. Auto Network Setup - Auto configure network on host bootup 2. Network Split - Allow ESP ans host to run network, with same IP Also updated main README to let user know scenarios and how to choose NG/ FG/ MCU solutions
feat(auto_ip_restore): 1. redefine hosted task priorities See merge request app-frameworks/esp_hosted!571
- on ESP-IDF v5.5 and above, use `uhci_ll_rx_set_eof_mode()` instead of `uhci_ll_set_eof_mode()`.
bugfix(c3_s3_uart_hci) Fix build error due to change in fn name See merge request app-frameworks/esp_hosted!574
Feat/c5 support idf v5.5 See merge request app-frameworks/esp_hosted!603
fix(esp_hosted_ng): Fix compile errors for ng See merge request app-frameworks/esp_hosted!606
docs(esp_hosted_ng): Update setup docs for esp_hosted ng See merge request app-frameworks/esp_hosted!609
fix(docs): Update sdio support for c5 See merge request app-frameworks/esp_hosted!610
fix(esp_hosted_ng): Fix De-assert HS signal on CS See merge request app-frameworks/esp_hosted!611
Docs/deassert cs spi See merge request app-frameworks/esp_hosted!612
Without the volatile keyword clang complains- volatile ensures this statement is not optimized out. My builds succeed after this change. espressif__esp_hosted/common/utils/esp_hosted_cli.c:203:2: error: indirection of non-volatile null pointer will be deleted, not trap [-Werror,-Wnull-dereference] 203 | *(int *) (0x0) = 0;
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a clang compiler warning by adding the volatile keyword to a null pointer dereference in a crash handler function. The change ensures that the intentional crash statement is not optimized away by the compiler.
- Adds
volatilequalifier to the null pointer cast in the crash handler - Resolves clang compiler error
-Werror,-Wnull-dereference - Maintains the intentional crash behavior while satisfying compiler requirements
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without the volatile keyword clang complains- volatile ensures this statement is not optimized out. My builds succeed after this change.
Clang error (before volatile keyword)
Testing
Passing gcc/clang builds.
Checklist
Before submitting a Pull Request, please ensure the following: