Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Args and configurable docker image source (RDT-971) #43

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

timoxd7
Copy link

@timoxd7 timoxd7 commented Apr 28, 2024

Configurable Docker image source

Added esp_idf_root to be used as source for the docker image. Can be used to select docker images hosted on different accounts or servers.

Additional arguments

Added additional_args to add custom arguments to the docker run command. Can be used to enable ccache usage, only add ccache ci action and add the following lines:

-v ./.ccache:/root/.ccache -e CCACHE_DIR=/root/.ccache

Only make sure the .ccache folder is created if no cache was already build (always on the first run).

Copy link
Collaborator

@kumekay kumekay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timoxd7 thank you for the contribution, it looks good to me.

I would only suggest a bit more precise names for the parameters you introduced.

And could you please describe them in the README.md too?

action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@key
Copy link

key commented Oct 18, 2024

It would be good if the image source could be switched.
@timoxd7 does not watch this PR?

@github-actions github-actions bot changed the title Additional Args and configurable docker image source Additional Args and configurable docker image source (RDT-971) Oct 18, 2024
@timoxd7
Copy link
Author

timoxd7 commented Oct 18, 2024

@key Sorry, forgot about it. Will check right now!

@timoxd7
Copy link
Author

timoxd7 commented Oct 18, 2024

@kumekay I just changed the names and added a documentation to the README.md file

@kumekay
Copy link
Collaborator

kumekay commented Oct 31, 2024

@timoxd7 Thank you, looks and works good,
I've tried it here https://github.com/kumekay/test_idf_action/actions/runs/11616606397

@kumekay kumekay merged commit e6f5c74 into espressif:v1 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants