-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(esp_http_server): prevent concurrent access to socket used in async http requests (IDFGH-13263) #14196
Conversation
👋 Hello fgrfl, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Thanks @fgrfl for the PR. Hello @chipweinberger, can you please take a look at the proposed change? |
it's been awhile since i've looked at this code but looks reasonable |
sha=4a7f37105659383e154d38d89fbc89cc26e29d9a |
This resolves #13998 with the proposed patch.
With this fix, once a request handler detaches itself from the main http thread with
httpd_req_async_handler_begin
, the main thread does not read from that socket until the asynchronous handler gives back the session context withhttpd_req_async_handler_complete
.