-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Explain revocation of unused but compromised keys (IDFGH-13688) #14563
Conversation
👋 Hello Lupindakaas, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lupindakaas thanks for the PR.
I have some nitpicks but overall changes look good to me.
@Lupindakaas Thanks for your quick revert. LGTM |
sha=b5f0e5c6af639d41bee0c970bae982967bca08e9 |
Explain the revocation of unused but compromised keys. docs: Apply updates from code review Add some nitpicks from AdityaHPatwardhan. Co-authored-by: Aditya Patwardhan <aditya.patwardhan@espressif.com>
@AdityaHPatwardhan Thanks for the review! I have (through many trials and trebulations) succesfully squashed the commits. Could you merge this PR? Have a nice day! |
sha=39d0eacde403051f8ecaa220f2cf4ca597c3f844 |
Description
This PR updates the Secure Boot V2 documentation to explain the revocation of unused but compromised keys.
Related
https://docs.espressif.com/projects/esp-idf/en/v5.2.2/esp32s3/security/secure-boot-v2.html#multiple-keys
Checklist
Before submitting a Pull Request, please ensure the following: