Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(https): Get TLS errors from http client (IDFGH-14265) #15059

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(https): Get TLS errors from http client (IDFGH-14265) #15059

wants to merge 2 commits into from

Conversation

KonssnoK
Copy link
Contributor

Description

Expose TLS errors from HTTPS client

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update components/esp_http_client/esp_http_client.c":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello KonssnoK, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against c485cfe

@KonssnoK KonssnoK force-pushed the feature/http_tls_error branch from 575b1f6 to 7373878 Compare December 19, 2024 08:37
@KonssnoK KonssnoK changed the title [https] Get TLS errors from http client feat(https): Get TLS errors from http client Dec 19, 2024
@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 19, 2024
@github-actions github-actions bot changed the title feat(https): Get TLS errors from http client feat(https): Get TLS errors from http client (IDFGH-14265) Dec 19, 2024
@nileshkale123 nileshkale123 added PR-Sync-Merge Pull request sync as merge commit and removed PR-Sync-Merge Pull request sync as merge commit labels Dec 20, 2024
@nileshkale123
Copy link
Collaborator

sha=737387885458924c23fddd541d784d721ad4043e

@nileshkale123 nileshkale123 added the PR-Sync-Merge Pull request sync as merge commit label Dec 20, 2024
nileshkale123
nileshkale123 suggested changes Dec 23, 2024
View reviewed changes
components/esp_http_client/esp_http_client.c Outdated Show resolved Hide resolved
components/esp_http_client/esp_http_client.c Outdated Show resolved Hide resolved
@KonssnoK KonssnoK force-pushed the feature/http_tls_error branch from 7373878 to 5642a72 Compare December 23, 2024 08:53
@nileshkale123 nileshkale123 added the PR-Sync-Update Pull request sync fetch new changes label Dec 30, 2024
@nileshkale123
Copy link
Collaborator

sha=5642a728bb30d0a989eefeab067c1df89574bc04

@nileshkale123 nileshkale123 added PR-Sync-Update Pull request sync fetch new changes and removed PR-Sync-Update Pull request sync fetch new changes labels Dec 30, 2024
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed and removed Status: Opened Issue is new labels Dec 31, 2024
nileshkale123
nileshkale123 suggested changes Jan 2, 2025
View reviewed changes
components/esp_http_client/include/esp_http_client.h Outdated
* @brief Get HTTPS client TLS last error
*
* @param[in] client The esp_http_client handle
* @param[out] esp_tls_error_code optional
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the meaning for these arguments by referring other API above. It should not be optional.

components/esp_http_client/include/esp_http_client.h
* @param[out] esp_tls_error_code optional
* @param[out] esp_tls_flags optional
*
* @return
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the return type as per the API.

@KonssnoK KonssnoK force-pushed the feature/http_tls_error branch from 5642a72 to 7dcbf43 Compare January 7, 2025 10:10
@KonssnoK
Copy link
Contributor Author

KonssnoK commented Jan 7, 2025

done

nileshkale123
nileshkale123 suggested changes Jan 9, 2025
View reviewed changes
components/esp_http_client/esp_http_client.c Outdated Show resolved Hide resolved
components/esp_http_client/include/esp_http_client.h
* This pointer could be NULL if caller does not care about esp_tls_code
*
* @return
* - ESP_FAIL if invalid parameters
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* - ESP_FAIL if invalid parameters
* - ESP_ERR_INVALID_STATE if invalid parameters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm it actually returns ESP_FAIL.. is ESP_ERR_INVALID_STATE a mask for that?

@nileshkale123
Copy link
Collaborator

Hello @KonssnoK ,

There are a few review comments, but LGTM!
Thanks for the contribution.

@KonssnoK @nileshkale123
Update components/esp_http_client/esp_http_client.c
c485cfe 
Co-authored-by: Nilesh Kale <nilesh.kale@espressif.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nileshkale123 nileshkale123 nileshkale123 requested changes

Assignees
No one assigned
Labels
PR-Sync-Merge Pull request sync as merge commit PR-Sync-Update Pull request sync fetch new changes Status: Reviewing Issue is being reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KonssnoK @nileshkale123 @espressif-bot