Added: display xCoreID in vTaskList #2064
Conversation
| @@ -181,6 +181,7 @@ typedef struct xTASK_STATUS | |||
| uint32_t ulRunTimeCounter; /*!< The total run time allocated to the task so far, as defined by the run time stats clock. See http://www.freertos.org/rtos-run-time-stats.html. Only valid when configGENERATE_RUN_TIME_STATS is defined as 1 in FreeRTOSConfig.h. */ | |||
| StackType_t *pxStackBase; /*!< Points to the lowest address of the task's stack area. */ | |||
| uint32_t usStackHighWaterMark; /*!< The minimum amount of stack space that has remained for the task since the task was created. The closer this value is to zero the closer the task has come to overflowing its stack. */ | |||
| BaseType_t xCoreID; | |||
There was a problem hiding this comment.
This line needs a comment similar to the lines above
There was a problem hiding this comment.
After looking BaseType_t definition in portmacro.h, BaseType_t type is int. I think uint32_t is more suitable for xCoreID.
#define portBASE_TYPE int
typedef portBASE_TYPE BaseType_t;
There was a problem hiding this comment.
No, I have taken made xCoreID have type BaseType_t because this is how the value is typed in the tskTaskControlBlock (tasks.c) where the value is sourced from.
components/freertos/tasks.c
Outdated
| @@ -4449,7 +4450,7 @@ For ESP32 FreeRTOS, vTaskExitCritical implements both portEXIT_CRITICAL and port | |||
| pcWriteBuffer = prvWriteNameToBuffer( pcWriteBuffer, pxTaskStatusArray[ x ].pcTaskName ); | |||
|
|
|||
| /* Write the rest of the string. */ | |||
| sprintf( pcWriteBuffer, "\t%c\t%u\t%u\t%u\r\n", cStatus, ( unsigned int ) pxTaskStatusArray[ x ].uxCurrentPriority, ( unsigned int ) pxTaskStatusArray[ x ].usStackHighWaterMark, ( unsigned int ) pxTaskStatusArray[ x ].xTaskNumber ); | |||
| sprintf( pcWriteBuffer, "\t%c\t%u\t%u\t%u\t%hd\r\n", cStatus, ( unsigned int ) pxTaskStatusArray[ x ].uxCurrentPriority, ( unsigned int ) pxTaskStatusArray[ x ].usStackHighWaterMark, ( unsigned int ) pxTaskStatusArray[ x ].xTaskNumber, ( int ) pxTaskStatusArray[ x ].xCoreID ); | |||
There was a problem hiding this comment.
Some existing code may rely on the format of the string returned by vTaskList. Suggest introducing a new sdkconfig option, e.g. CONFIG_FREERTOS_VTASKLIST_INCLUDE_COREID, disabled by default. Then put the modifications under ifdef, so that by default the old behavior is preserved.
There was a problem hiding this comment.
And here int could be "unsigned int" or "uint32_t" following above comment.
There was a problem hiding this comment.
Added the option CONFIG_FREERTOS_VTASKLIST_INCLUDE_COREID as requested. Please se the revised Pull Request.
|
Thanks for approving this. |
|
Hi @dmcnaugh, sorry for the slow turnaround. I've put this into review/merge queue, the changes should be in master branch in a few days. |
|
Cherry-picked in 0fb1945, thanks! |
Proposed solution for [TW#16439] FreeRTOS xTaskList should be extended to show xCoreID for SMP #1260