Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check slot_config for null before using it (IDFGH-2967) #5000

Closed
wants to merge 1 commit into from
Closed

Check slot_config for null before using it (IDFGH-2967) #5000

wants to merge 1 commit into from

Conversation

biodranik
Copy link
Contributor

No description provided.

@github-actions github-actions bot changed the title Check slot_config for null before using it Check slot_config for null before using it (IDFGH-2967) Mar 26, 2020
@Alvin1Zhang Alvin1Zhang requested a review from ginkgm March 26, 2020 11:22
Yexo
Yexo suggested changes Apr 8, 2020
View reviewed changes
Copy link

@Yexo Yexo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check if (!(slot == 0 || slot == 1)) { needs to be moved up as well above the call to sdmmc_host_pullup_en.

@biodranik
Copy link
Contributor Author

@Yexo Thanks! Fixed.

@igrr igrr closed this in fb0fa34 Jun 12, 2020
espressif-bot pushed a commit that referenced this pull request Jun 15, 2020
@biodranik @Icarus113
sdmmc: Correctly check function parameters before using them
cccd679 
Closes #5000
espressif-bot pushed a commit that referenced this pull request Jun 15, 2020
@biodranik @Icarus113
sdmmc: Correctly check function parameters before using them
7eaea6c 
Closes #5000
espressif-bot pushed a commit that referenced this pull request Sep 10, 2020
@biodranik @Icarus113
sdmmc: Correctly check function parameters before using them
29d3c40 
Closes #5000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yexo Yexo Yexo requested changes

@ginkgm ginkgm Awaiting requested review from ginkgm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biodranik @Yexo