Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i2c.c to consider two I2C buses for clear bus counter (IDFGH-5398) #7144

Closed
wants to merge 1 commit into from

Conversation

iltis42
Copy link
Contributor

@iltis42 iltis42 commented Jun 13, 2021

Fix issue with single bus clear counter but two I2C buses (I2C0, I2C1). The previously implemented single (static) counter would impact the second bus either if one bus has counter expiry.

Fix issue with single bus clear counter but two I2C buses (I2C0, I2C1). The previously implemented single (static) counter would impact the second bus either if one bus has counter expiry.
@CLAassistant
Copy link

CLAassistant commented Jun 13, 2021

CLA assistant check
All committers have signed the CLA.

@iltis42 iltis42 changed the title Update i2c.c Update i2c.c to consider two I2C buses for clear bus counter Jun 13, 2021
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jun 13, 2021
@github-actions github-actions bot changed the title Update i2c.c to consider two I2C buses for clear bus counter Update i2c.c to consider two I2C buses for clear bus counter (IDFGH-5398) Jun 13, 2021
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@iltis42
Copy link
Contributor Author

iltis42 commented Jul 16, 2022

Any news about this ?
The single counter is obviously an epic bug, any dual I2C bus board will run into that issue.

@o-marshmallow
Copy link
Collaborator

sha=2cb7ae03072ad7f3f580fee577e626f3c3ef08c8

@o-marshmallow o-marshmallow added the PR-Sync-Rebase Pull request sync as rebase commit label Jul 18, 2022
@o-marshmallow
Copy link
Collaborator

Hi @iltis42 ,
I am going to handle it to get it merged in master.

@espressif-bot espressif-bot added Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Aug 8, 2022
espressif-bot pushed a commit that referenced this pull request Aug 9, 2022
Fix issue with single bus clear counter but two I2C buses (I2C0, I2C1). The previously implemented single (static) counter would impact the second bus either if one bus has counter expiry.
Merges #7144
@Alvin1Zhang
Copy link
Collaborator

Changes merged with 0257eba, thanks for your contribution again.

espressif-bot pushed a commit that referenced this pull request Nov 18, 2022
Fix issue with single bus clear counter but two I2C buses (I2C0, I2C1). The previously implemented single (static) counter would impact the second bus either if one bus has counter expiry.
Merges #7144
espressif-bot pushed a commit that referenced this pull request Dec 11, 2022
Fix issue with single bus clear counter but two I2C buses (I2C0, I2C1). The previously implemented single (static) counter would impact the second bus either if one bus has counter expiry.
Merges #7144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Rebase Pull request sync as rebase commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants