ci: Add unit test suite to validate tcp state transitions

espressif · May 10, 2023 · f50c87d · f50c87d
1 parent a6874a4
commit f50c87d
Show file tree

Hide file tree

Showing 6 changed files with 670 additions and 1 deletion.
diff --git a/test/unit/Filelists.cmake b/test/unit/Filelists.cmake
@@ -31,6 +31,7 @@ set(LWIP_TESTFILES
  ${LWIP_TESTDIR}/mqtt/test_mqtt.c
  ${LWIP_TESTDIR}/tcp/tcp_helper.c
  ${LWIP_TESTDIR}/tcp/test_tcp_oos.c
+ ${LWIP_TESTDIR}/tcp/test_tcp_state.c
  ${LWIP_TESTDIR}/tcp/test_tcp.c
  ${LWIP_TESTDIR}/udp/test_udp.c
  ${LWIP_TESTDIR}/ppp/test_pppos.c

diff --git a/test/unit/Filelists.mk b/test/unit/Filelists.mk
@@ -47,6 +47,7 @@ TESTFILES=$(TESTDIR)/lwip_unittests.c \
  $(TESTDIR)/mqtt/test_mqtt.c \
  $(TESTDIR)/tcp/tcp_helper.c \
  $(TESTDIR)/tcp/test_tcp_oos.c \
+ $(TESTDIR)/tcp/test_tcp_state.c \
  $(TESTDIR)/tcp/test_tcp.c \
  $(TESTDIR)/udp/test_udp.c \
  $(TESTDIR)/ppp/test_pppos.c

diff --git a/test/unit/lwip_unittests.c b/test/unit/lwip_unittests.c
@@ -5,6 +5,7 @@
 #include "udp/test_udp.h"
 #include "tcp/test_tcp.h"
 #include "tcp/test_tcp_oos.h"
+#include "tcp/test_tcp_state.h"
 #include "core/test_def.h"
 #include "core/test_dns.h"
 #include "core/test_mem.h"
@@ -79,6 +80,7 @@ int main(void)
  udp_suite,
  tcp_suite,
  tcp_oos_suite,
+ tcp_state_suite,
  def_suite,
  dns_suite,
  mem_suite,

diff --git a/test/unit/tcp/tcp_helper.c b/test/unit/tcp/tcp_helper.c
@@ -25,7 +25,11 @@ tcp_remove(struct tcp_pcb* pcb_list)
  while(pcb != NULL) {
  pcb2 = pcb;
  pcb = pcb->next;
- tcp_abort(pcb2);
+ if (pcb2->state == LISTEN) {
+ tcp_close(pcb2);
+ } else {
+ tcp_abort(pcb2);
+ }
  }
 }
 
@@ -260,6 +264,7 @@ void test_tcp_input(struct pbuf *p, struct netif *inp)
  ip_addr_copy_from_ip4(*ip_current_src_addr(), iphdr->src);
  ip_current_netif() = inp;
  ip_data.current_ip4_header = iphdr;
+ ip_data.current_input_netif = inp;
 
  /* since adding IPv6, p->payload must point to tcp header, not ip header */
  pbuf_header(p, -(s16_t)sizeof(struct ip_hdr));