core/ipv4/dhcp: add hostname option to dhcp request on reboot (IDFGH-3013) #6

nightvisi0n · 2019-03-28T23:30:46Z

Unfortunately the DHCP option "hostname" (12) wasn't set in the "reboot"
dhcp message until now. dhcp_reboot is executed in each of the following
cases: REBIND, RENEW, BOUND, REBOOTING
If the dhcp server uses the hostname option in order to create matching
dns records (which is common), it wasn't possible to change its DNS
record after its initial dhcp request.
The only possibility to change the hostname was to trigger a reboot
(or a dhcp_stop).

The recent changes of 3b88e84 made the
situation even worse. Since the last valid ip address obtained from the
DHCP server is now stored in non-volatile storage, it was not even
possible to change the hostname with a reboot of the device, since even
then a dhcp_reboot message (with the hostname option missing) is sent
(instead of a fresh dhcp request).

This fix is already implemented in the upstream version of lwip:
http://git.savannah.nongnu.org/cgit/lwip.git/commit/?id=d65681a7d7a13a220c7bab9093c717b151d3719c

Unfortunately the DHCP option "hostname" (12) wasn't set in the "reboot" dhcp message until now. dhcp_reboot is executed in each of the following cases: REBIND, RENEW, BOUND, REBOOTING If the dhcp server uses the hostname option in order to create matching dns records (which is common), it wasn't possible to change its DNS record after its initial dhcp request. The only possibility to change the hostname was to trigger a reboot (or a dhcp_stop). The recent changes of 3b88e84 made the situation even worse. Since the last valid ip address obtained from the DHCP server is now stored in non-volatile storage, it was not even possible to change the hostname with a reboot of the device, since even then a dhcp_reboot message (with the hostname option missing) is sent (instead of a fresh dhcp request). This fix is already implemented in the upstream version of lwip. Signed-off-by: julian <dev@jneureuther.de>

nightvisi0n · 2019-03-28T23:32:02Z

Related: 0865edf

mvadu · 2020-02-16T20:45:05Z

@nightvisi0n what happened to this PR? Current head has code similar to this PR, but using arduino-esp32 I still don't see host name sent via DHCPREQUEST

#if LWIP_NETIF_HOSTNAME
    options_out_len = dhcp_option_hostname(options_out_len, msg_out->options, netif);
#endif /* LWIP_NETIF_HOSTNAME */

Alvin1Zhang · 2020-04-01T03:47:53Z

@nightvisi0n @mvadu Thanks for the contribution and updates, and sorry for the slow turnaround, and appreciate your patience with the PR. We will evaluate and provide feedback. Thanks.

freakyxue · 2020-04-01T06:17:07Z

hi @lsgunth
I saw one of your records saying the changes were misplaced。
lwip2.1.2 fix conmmit:13665c14e19dfda6b2ad30c1e5d88e0415cf8b7a.
This change is that lwip2.0.3 reboot is missing hostname.

lsgunth · 2020-04-01T15:30:56Z

Sorry, my mistake. I confused this with a different PR.

nightvisi0n · 2020-04-01T16:12:48Z

I just had a look at the current state of this PR.

@mvadu It seems like this was implemented in the latest 2.1.2-esp branch with d65681a.

It was also fixed int the 2.0.3-esp branch in january: 057f7f6

ESP-IDF is using the latest 2.1.2-esp since release v4.0, but for projects which are using the older v3.3 release this issue is still not fixed, because the latest ESP-IDF v3.3 release (v3.3.1) does not contain this fix.

This is also the case for the popular arduino-esp32 project, which is currently using this commit in the v3.3 esp-idf branch: espressif/esp-idf@367c3c09c (see: https://github.com/espressif/arduino-esp32/blob/master/tools/sdk/include/config/sdkconfig.h#L383). (related issue there: espressif/arduino-esp32#2537)

@freakyxue I think we can close this PR, since this bug has already been fixed by you in another commit.

Alvin1Zhang · 2020-04-02T02:53:15Z

@nightvisi0n Thanks for your contribution.

AntumArk · 2020-08-18T10:23:25Z

I am running v4 release branch of esp.idf Aug 11 2020, and still having this issue. And 602d25c of lwip. Somehow my router detected hostname once and now it does not change. I have also tried finding ip address with c# application, and "FreeIpScanner", but it does not show up.

Is there some deeper issue? I have also tried running with V4.2 branch, but no luck.

freakyxue · 2020-08-19T06:13:34Z

hi @AntumArk
Please provide the complete capture file

AntumArk · 2020-08-19T06:23:52Z

@freakyxue how do i do that?

freakyxue · 2020-08-19T06:34:37Z

hi @AntumArk
Lwip2.1.2 and LwIP 2.0.3 have fixed this problem, but you still have it. I need to provide a snapshot of the process of ESP32 DHCP access, so that I can analyze this problem

AntumArk · 2020-08-19T07:31:35Z

hi @AntumArk
Lwip2.1.2 and LwIP 2.0.3 have fixed this problem, but you still have it. I need to provide a snapshot of the process of ESP32 DHCP access, so that I can analyze this problem

@freakyxue Is there an option in sdkconfig to provide more information? I am not really familiar with debugging TCP/IP protocols.

AntumArk · 2020-08-19T08:24:58Z

Windows OS - finds only localhost hostname, Linux- finds all hostnames including ESP32. So apparently it is OS based problem... It is good that I have remembered to try pinging through RPI :D . That is why my router detected the hostname.

freakyxue · 2020-08-19T08:47:07Z

hi @ AntumArk
I think you should have found the problem. It should not be LwIP's bug

Reproducer (in bash): base64 -d <<< "H4sIAP/9L2QCA+3WoQ2AMBSE4QoCTFHBBJfgSRF4RDfpRmgmYBpGQRBCk4ZiSfk/+fJMK+5dZRVpzSQzSs6oPierDV4y87WxLQLwE42SfNCdDyHJB9/xZwAARPbMJbUq4JJmu4JVT1cAAACfbGIqoqcMzy90eu+aBw2+N28WFgAA" | gunzip | test/fuzz/lwip_fuzz2 Crash log: ../../src/core/altcp_tcp.c:178:13: runtime error: member access within null pointer of type 'struct tcp_pcb' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../src/core/altcp_tcp.c:178:13 in AddressSanitizer:DEADLYSIGNAL ================================================================= ==192415==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000048 (pc 0x557065081703 bp 0x0aae0cb71204 sp 0x7ffd034dabc0 T0) ==192415==The signal is caused by a READ memory access. ==192415==Hint: address points to the zero page. #0 0x557065081703 in altcp_tcp_setup_callbacks /.../lwip/test/fuzz/../../src/core/altcp_tcp.c:178:19 espressif#1 0x55706508206f in altcp_tcp_setup /.../lwip/test/fuzz/../../src/core/altcp_tcp.c:189:3 espressif#2 0x55706508206f in altcp_tcp_accept /.../lwip/test/fuzz/../../src/core/altcp_tcp.c:84:5 espressif#3 0x557065095592 in tcp_input /.../lwip/test/fuzz/../../src/core/tcp_in.c:380:9 espressif#4 0x5570650e752f in ip4_input /.../lwip/test/fuzz/../../src/core/ipv4/ip4.c:743:9 espressif#5 0x55706513d4de in ethernet_input /.../lwip/test/fuzz/../../src/netif/ethernet.c:186:9 espressif#6 0x557064fe0959 in input_pkt /.../lwip/test/fuzz/fuzz_common.c:209:9 espressif#7 0x557064fdeb6a in input_pkts /.../lwip/test/fuzz/fuzz_common.c:257:9 espressif#8 0x557064fdeb6a in lwip_fuzztest /.../lwip/test/fuzz/fuzz_common.c:669:3 espressif#9 0x7ff4f578e189 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 espressif#10 0x7ff4f578e244 in __libc_start_main csu/../csu/libc-start.c:381:3 espressif#11 0x557064f20420 in _start (/.../lwip/test/fuzz/lwip_fuzz2+0x81420) (BuildId: 8680a96430d5749c90111fe9c3a3d4f881a5dbcd) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV /.../lwip/test/fuzz/../../src/core/altcp_tcp.c:178:19 in altcp_tcp_setup_callbacks ==192415==ABORTING Aborted

This was referenced Mar 28, 2019

Hostname not sent via DHCP request (IDFGH-694) espressif/esp-idf#3150

Closed

Hostname not sent via DHCP request espressif/arduino-esp32#2537

Closed

rjwats mentioned this pull request Apr 27, 2019

[ESP8266/ESP32] Problem setting hostname while on dynamic ip. rjwats/esp8266-react#17

Merged

jack0c force-pushed the 2.0.3-esp branch from 5d9fce0 to fe9a58c Compare November 13, 2019 13:33

lsgunth mentioned this pull request Nov 19, 2019

dhcp: Set hostname for DISCOVER packets (IDFGH-2922) #9

Closed

github-actions bot changed the title ~~core/ipv4/dhcp: add hostname option to dhcp request on reboot~~ core/ipv4/dhcp: add hostname option to dhcp request on reboot (IDFGH-3013) Mar 31, 2020

Alvin1Zhang closed this Apr 2, 2020

DAVe3283 mentioned this pull request Aug 18, 2020

ESP8266 not registering hostname in DHCP esphome/issues#1123

Open

agners mentioned this pull request May 16, 2021

No Host Name option (12) in DHCP request esphome/issues#2057

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

core/ipv4/dhcp: add hostname option to dhcp request on reboot (IDFGH-3013) #6

core/ipv4/dhcp: add hostname option to dhcp request on reboot (IDFGH-3013) #6

Uh oh!

nightvisi0n commented Mar 28, 2019 •

edited

Loading

Uh oh!

nightvisi0n commented Mar 28, 2019

Uh oh!

mvadu commented Feb 16, 2020

Uh oh!

Alvin1Zhang commented Apr 1, 2020

Uh oh!

freakyxue commented Apr 1, 2020

Uh oh!

lsgunth commented Apr 1, 2020

Uh oh!

nightvisi0n commented Apr 1, 2020 •

edited

Loading

Uh oh!

Alvin1Zhang commented Apr 2, 2020

Uh oh!

AntumArk commented Aug 18, 2020

Uh oh!

freakyxue commented Aug 19, 2020

Uh oh!

AntumArk commented Aug 19, 2020

Uh oh!

freakyxue commented Aug 19, 2020

Uh oh!

AntumArk commented Aug 19, 2020 •

edited

Loading

Uh oh!

AntumArk commented Aug 19, 2020 •

edited

Loading

Uh oh!

freakyxue commented Aug 19, 2020

Uh oh!

Uh oh!

core/ipv4/dhcp: add hostname option to dhcp request on reboot (IDFGH-3013) #6

core/ipv4/dhcp: add hostname option to dhcp request on reboot (IDFGH-3013) #6

Uh oh!

Conversation

nightvisi0n commented Mar 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nightvisi0n commented Mar 28, 2019

Uh oh!

mvadu commented Feb 16, 2020

Uh oh!

Alvin1Zhang commented Apr 1, 2020

Uh oh!

freakyxue commented Apr 1, 2020

Uh oh!

lsgunth commented Apr 1, 2020

Uh oh!

nightvisi0n commented Apr 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alvin1Zhang commented Apr 2, 2020

Uh oh!

AntumArk commented Aug 18, 2020

Uh oh!

freakyxue commented Aug 19, 2020

Uh oh!

AntumArk commented Aug 19, 2020

Uh oh!

freakyxue commented Aug 19, 2020

Uh oh!

AntumArk commented Aug 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AntumArk commented Aug 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

freakyxue commented Aug 19, 2020

Uh oh!

Uh oh!

nightvisi0n commented Mar 28, 2019 •

edited

Loading

nightvisi0n commented Apr 1, 2020 •

edited

Loading

AntumArk commented Aug 19, 2020 •

edited

Loading

AntumArk commented Aug 19, 2020 •

edited

Loading