Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQTT_EVENT_UNSUBSCRIBED has a additional context: msg_id! (IDFGH-7950) #233

Closed
liang-zhu-zi opened this issue Jul 30, 2022 · 1 comment
Closed

MQTT_EVENT_UNSUBSCRIBED has a additional context: msg_id! (IDFGH-7950) #233

liang-zhu-zi opened this issue Jul 30, 2022 · 1 comment
Labels
Resolution: Done Status: Done

Comments

@liang-zhu-zi
Copy link

MQTT_EVENT_UNSUBSCRIBED 的注释如下：

typedef enum esp_mqtt_event_id_t {
    ...
    MQTT_EVENT_UNSUBSCRIBED, /*!< unsubscribed event */
    ...
} esp_mqtt_event_id_t;

但实际上， MQTT_EVENT_UNSUBSCRIBED 有一个 msg_id 的附加内容，应修改其注释如下：

typedef enum esp_mqtt_event_id_t {
    ...
    MQTT_EVENT_UNSUBSCRIBED, /*!< unsubscribed event, additional context:  msg_id */
    ...
} esp_mqtt_event_id_t;
@github-actions github-actions bot changed the title MQTT_EVENT_UNSUBSCRIBED has a additional context: msg_id! MQTT_EVENT_UNSUBSCRIBED has a additional context: msg_id! (IDFGH-7950) Jul 30, 2022
@david-cermak
Copy link
Collaborator

@liang-zhu-zi Good point, thanks for noticing! Please feel free to file a PR with this update of documentation. will be happy to accept it and merge. (otherwise, will fix later)

espressif-bot pushed a commit to espressif/esp-idf that referenced this issue Dec 22, 2022
@euripedesrocha
mqtt: Set state on stoping; Add error code to Subscribed event
4ec9d4b 
* Update submodule: git log --oneline ae53d799da294f03ef65c33e88fa33648e638134..fde00340f19b9f5ae81fff02ccfa9926f0e33687

Detailed description of the changes:
* Fix the default configuration for event queue
  - See merge request espressif/esp-mqtt!153
  - See commit espressif/esp-mqtt@fb42588
* Adds missing header.
  - See merge request espressif/esp-mqtt!152
  - See commit espressif/esp-mqtt@8a60057
* Moves state change when stopping the client
  - See merge request espressif/esp-mqtt!150
  - Closes espressif/esp-mqtt#239
  - See commit espressif/esp-mqtt@3738fcd
* Adds error code to MQTT_EVENT_SUBSCRIBED in case of failure
  - See merge request espressif/esp-mqtt!143
  - - Closes espressif/esp-mqtt#233
  - See commit espressif/esp-mqtt@9af5c26
* Adds debug information on sending dup messages
  - See merge request espressif/esp-mqtt!145
  - See commit espressif/esp-mqtt@47b3f9b
* ci: Fix qemu build
  - See merge request espressif/esp-mqtt!147
  - See commit espressif/esp-mqtt@68e8c4f
* ci: Build and Test QEMU on v5.0
  - See merge request espressif/esp-mqtt!142
  - See commit espressif/esp-mqtt@9db9ee7
* client: Add support for user events
  - See merge request espressif/esp-mqtt!140
  - Closes espressif/esp-mqtt#230
  - See commit espressif/esp-mqtt@97503cc
* Adds unregister event API
  - See merge request espressif/esp-mqtt!139
  - Closes #9194
  - See commit espressif/esp-mqtt@a9a9fe7
egnor pushed a commit to egnor/esp-mqtt that referenced this issue Dec 23, 2022
@euripedesrocha @egnor
Adds error code to MQTT_EVENT_SUBSCRIBED in case of failure
7b2172f 
- Payload data parsed for error codes. Check only for first filter
  because our subscribe function only handle one topic filter in each
  call.

- Closes espressif#233
egnor pushed a commit to egnor/esp-mqtt that referenced this issue Dec 23, 2022
@euripedesrocha @egnor
Adds error code to MQTT_EVENT_SUBSCRIBED in case of failure
d1d8984 
- Payload data parsed for error codes. Check only for first filter
  because our subscribe function only handle one topic filter in each
  call.

- Closes espressif#233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Done Status: Done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@david-cermak @espressif-bot @liang-zhu-zi