Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix format warnings (IDFGH-7768) #79

Closed
2 tasks
Lapshin opened this issue Jul 7, 2022 · 3 comments
Closed
2 tasks

fix format warnings (IDFGH-7768) #79

Lapshin opened this issue Jul 7, 2022 · 3 comments
Assignees
@gabsuren

Comments

@Lapshin
Copy link
Contributor

Lapshin commented Jul 7, 2022 •
edited
Loading

Related to #73

TODO:

  • Remove -Wno-format compiler option
  • Fix all format warings

esp_modem is affected
@github-actions github-actions bot changed the title fix format warnings fix format warnings (IDFGH-7768) Jul 7, 2022
euripedesrocha pushed a commit to euripedesrocha/esp-protocols that referenced this issue Oct 17, 2022
@tore-espressif @euripedesrocha
esp_modem: Fix format warnings
14cf562 
Closes espressif#79
@igrr
Copy link
Member

igrr commented Oct 18, 2022

I think this should be reopened as there is still -Wno-format in esp_websocket_client:

esp-protocols/components/esp_websocket_client/CMakeLists.txt

Line 13 in 5097065

target_compile_options(${COMPONENT_LIB} PRIVATE "-Wno-format")

@david-cermak david-cermak reopened this Oct 21, 2022
gabsuren pushed a commit to gabsuren/esp-protocols-1 that referenced this issue Oct 31, 2022
@tore-espressif @suren-gabrielyan-espressif
esp_modem: Fix format warnings
0dc1643 
Closes espressif#79
@david-cermak david-cermak reopened this Feb 26, 2024
@david-cermak
Copy link
Collaborator

Reopening as there're still some -Wno-format used in the examples.

Need to fix slip_custom_netif and esp_modem (linux example), and remove the mqtt example

david-cermak added a commit to david-cermak/esp-protocols that referenced this issue Feb 28, 2024
@david-cermak
fix(modem): Fix remaining print format warnings
3b80181 
Partially addresses espressif#79
david-cermak added a commit to david-cermak/esp-protocols that referenced this issue Feb 28, 2024
@david-cermak
fix(examples): Fix MQTT example print format warnings
a06de64 
Partially addresses espressif#79
@david-cermak
Copy link
Collaborator

Closing as the examples mentioned above have been fix on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabsuren gabsuren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gabsuren @igrr @Lapshin @david-cermak @espressif-bot