-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Power metering (MEGH-3343) #121
base: master
Are you sure you want to change the base?
Conversation
…st to int and most meters w/ Modbus seem to go with floats anyway
@brainstorm , we have some reservations for this PR because ESP standard devices/params are typically meant for special handling either in our official phone apps or our 3rd party integrations like Alexa/GVA. Since there is no "power meter" category in Alexa/GVA and no immediate plan to add this in the phone apps either, we will need some more time to decide whether to merge this or not. I will also check internally to see if anyone had created any demo for Energy meters, and if some names were already chosen. Meanwhile, since custom examples need not use standard types, I am hoping that this isn't blocking any of your projects. |
Thanks @shahpiyushv, it doesn't block any of my projects, I was just going by the same moves as #105, didn't know about Alexa/GVA side of things since I don't own one nor I'm interested in them. I guess that I could do the same thing just sticking with Feel free to close this PR it in any case if it doesn't serve yours or Espressif's needs. Cheers! |
…nto power_metering
…nto power_metering
I wanted to contribute power metering cluster/attributes writing on the Matter spec after reading the relevant Matter 1.0 spec PDFs: https://csa-iot.org/wp-content/uploads/2022/10/22-27349-001_Matter-1.0-Core-Specification76.pdf But apparently it's a private repository so the public cannot make pull requests?: project-chip/connectedhomeip#23339 (comment) I guess that for now I'll have to go with the custom data model documented on esp-matter docs to match the power metering needs (fairly close to i.e the temperature sensor present in the 1.0 Matter spec anyway). Not ideal since I guess it'll complicate the Matter certification process later on, so please let me know if there's some avenue where I can contribute to the official spec without the pricey membership model/tiers from csa-iot. |
@brainstorm I think it is not possible right now |
Add power meter basic type and parameter, akin to temperature and #105 (humidity sensor).
More context over:
https://esp32.com/viewtopic.php?f=13&p=94595#p94595
https://github.com/brainstorm/yigedianqi-modbus/
https://github.com/brainstorm/yigedianqi-modbus/tree/esp-idf-rainmaker