Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rev 0 for P4 #254

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

Description

This PR adds a support for rev 0 of P4, which should also solve the issue with Wokwi Simulator CI tests.
Also a C6 config line inside a P4 defconfig was commented out.

Related

Testing

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@@ -4,7 +4,7 @@ CONFIG_SPIRAM_SPEED_200M=y
# CONFIG_ESP_TASK_WDT_CHECK_IDLE_TASK_CPU1 is not set
CONFIG_LWIP_TCP_SACK_OUT=y

CONFIG_SLAVE_IDF_TARGET_ESP32C6=y
# CONFIG_SLAVE_IDF_TARGET_ESP32C6=y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line tells esp-hosted what MCU is used for WiFi. Please revert!

@me-no-dev me-no-dev merged commit 7227862 into espressif:release/v5.3 Dec 10, 2024
9 checks passed
me-no-dev added a commit that referenced this pull request Dec 18, 2024
* fix(build): Changes required to build against IDF v5.3

* Use unified Xtensa toolchain

* add(build): Add initial ESP32-P4 skeleton

Chip is not selected by default and has only one memory and bootloader configuration. This is the minimum required to issue `build.sh -t esp32p4` which will currently fail, because Arduino support is not yet ready

* feat(esp32p4): Build libs for ESP32-P4 (#221)

* feat(esp32p4): Build libs for ESP32-P4

* Add target to workflows

* Enable in builds

* Remove bluedroid patch

* Add P4 to libspi

* Add P4 mem variants

* Update SDK in JSON even if version did not change (#223)

* Do not build matter for ESP32-P4

* Update ESP-DL configuration

* Add additional DL models and use extra components only when needed

* Use extra DL models only on S3 and P4

* Switch to the new ESP-DL only for ESP32-P4

* Rename old DL component and revert the name of the new

* Enable TinyUSB build for ESP32P4

* Add support for HighSpeed USB in arduino_tinyusb

* Update tinyusb dcd_dwc2

* Add P4 configuration for PSRAM, WDT and ESP-HOSTED

* Update dcd_dwc2.c

* Remove conditional inclusion of builder specified components

CCACHE is very fast and it also causes issues with memory variants

* Do not use ESP-DL on P4

* Update P4 PSRAM Speed to 200MHz

* Fixes Matter over WiFi to disable OpenThread (#232)

* Fixes Matter over WiFi to disable OpenThread

* fix flag value

* disables Matter Stack WiFi manager

* rollback Matter WiFi Manager changes

* Add define to signify that prebuilt libs are used

* Enable FreeRTOS Trace Facility (#234)

* Enable FreeRTOS Trace Facility

* Enable more statistics

* fix(docker): Add docker tag to run scripts in 5.3 branch (#236)

* fix(docker): Add docker tag to run scripts in 5.3 branch

* Add additional info

* fix(zigbee): Unlink the zigbee libs (#242)

* fix(): Move mkdir to top as its already used

* Update TinyUSB DCD Source

* Add missing compile source from TinyUSB

* Fix path to TinyUSB dwc2_common.c

* Update TinyUSB DCD

* Update TinyUSB DCD

* Update dcd_dwc2.c

* Update dcd_dwc2.c

* Update copy-libs.sh

* Support rev 0 for P4 (#254)

* Support rev 0 for P4

* Revert C6 slave idf target

* Fix the crash for esp32 and esp32c3 (#248)

* fix(trademark): Remove 3rd party trademarks from scripts (#255)

* Update dcd_dwc2.c

* Prepare for merging release/v5.3 into master

---------

Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
Co-authored-by: kvp1703 <65121235+kvp1703@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants