Draft: replace full sdkconfig files with sdkconfig.defaults #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated using idf.py save-defconfig (cherry-picked from IDF commit 5118dd7c). ESP-IDF version used for generating the configs: v4.4 release tag.
|
Seems that sdkconfig.defaults.TARGET are not applied when building. Is it possible that the build system expects them to be where sdkconfig will be generated? BTW what is the reason to relocate it to the build folder? |
|
It would be nice if the |
|
or you could have entered menuconfig and pressed |
|
closing in favor of the s3 support branch, where such configs are used |
|
@me-no-dev Can I consider issue 6187 as closed? |
|
will be closed when we merge S3 support :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st step: sdkconfig.TARGET -> sdkconfig.defaults.TARGET
In this step, sdkconfig file for each target is replaced with an sdkconfig.defaults file. All the options which are set to default values are removed, only the options different from the default values are kept.
This is done using
idf.py save-defconfigscript (cherry-picked from IDF commit 5118dd7c). ESP-IDF version used for generating the configs: v4.4 release tag.Generated
sdkconfigfile is moved into thebuilddirectory.The build scripts adjusted accordingly.
2nd step (TODO)
From the generated sdkconfig.defaults.TARGET files it can be seen that the settings for the 3 targets are different, even for some options which don't seem to be target-specific.
Need to make a list of all the options which aren't the same for the 3 targets and to check whether this is expected.
Related