-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reset modes #146
Add reset modes #146
Conversation
Download the artifacts for this pull request: |
b884a1f
to
0276d7f
Compare
Ok, tested and it's still resetting. I believe this is because you are now calling reset in 2 locations (probably due to the rebasing).
It seems like it would be best to combine the 2 functions and return an array of reset sequences. Perhaps if mode is "no_reset", then possibly return an empty array and leave the call inside of _connectAttempt like it is now. To deal with the empty array maybe have some kind of empty reset sequence or just avoid calling the reset function altogether. Either way, I think a combination of the 2 methods would work best. Would you like me to make a PR for this PR or you just handle it? |
Thank you for the fix @makermelissa I've pushed the changed from #181 here. Could you test it again ? |
Of course. |
Tested and it is working great. |
* add before after reset modes * Combine reset sequence constructor functions (#181) * update pages node version rm duplicate debug msg * add after hard reset in live demo --------- Co-authored-by: Melissa LeBlanc-Williams <melissa@adafruit.com> npm audit test pages use ubuntu 20 update pages yml add parcel workers 0 parcel build workers rm debug action update action version
Fix #43
Fix #177
Fix #178
Add Before and after reset modes options