espsecure: Run AES-XTS encryption in O(n) instead of O(n^2) time complexity (ESPTOOL-523) #783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The espsecure tool is currently very slow at encrypting large files with AES-XTS. The code currently runs in$O(n^2)$ time complexity, which is very bad.
Some timing I did on my computer:
With this patch, these are the new results:
I have run the esptool.py automated integration tests with this change. The results were: