fix: Address issue with the cdt-lsp-2.0.0 #1021
Conversation
WalkthroughThe recent updates to the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- bundles/com.espressif.idf.lsp/src/com/espressif/idf/lsp/preferences/IDFClangdOptionsDefaults.java (2 hunks)
Additional comments not posted (7)
bundles/com.espressif.idf.lsp/src/com/espressif/idf/lsp/preferences/IDFClangdOptionsDefaults.java (7)
26-31: LGTM!The
clangdPathmethod correctly retrieves and logs the clangd executable path, returning a default value if not found.
33-39: LGTM!The
queryDrivermethod correctly retrieves and logs the toolchain executable path, returning an empty string if not found.
42-44: LGTM!The
useTidymethod correctly returns a fixed value indicating whether to use Tidy.
47-49: LGTM!The
useBackgroundIndexmethod correctly returns a fixed value indicating whether to use Background Index.
52-54: LGTM!The
completionStylemethod correctly returns a fixed value indicating the completion style.
57-59: LGTM!The
prettyPrintmethod correctly returns a fixed value indicating whether to use Pretty Print.
62-63: LGTM!The
additionalOptionsmethod correctly returns an empty list of additional options.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- bundles/com.espressif.idf.lsp/src/com/espressif/idf/lsp/preferences/IDFClangdOptionsDefaults.java (3 hunks)
Additional comments not posted (7)
bundles/com.espressif.idf.lsp/src/com/espressif/idf/lsp/preferences/IDFClangdOptionsDefaults.java (7)
Line range hint
26-32:
LGTM!The
clangdPathmethod is correctly implemented with appropriate logging and fallback mechanisms.
36-42: LGTM!The
queryDrivermethod is correctly implemented with appropriate logging and fallback mechanisms.
44-48: LGTM!The
useTidymethod is straightforward and correctly implemented.
50-54: LGTM!The
useBackgroundIndexmethod is straightforward and correctly implemented.
56-60: LGTM!The
completionStylemethod is straightforward and correctly implemented.
62-66: LGTM!The
prettyPrintmethod is straightforward and correctly implemented.
68-72: LGTM!The
additionalOptionsmethod is straightforward and correctly implemented.
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
releng/com.espressif.idf.target/com.espressif.idf.target.target (1)
93-93: The version0.0.0fororg.yaml.snakeyamldoes not appear to be valid.Both the Maven Central Repository and the GitHub repository for
snakeyamldo not list this version. Please verify and correct the version if necessary.
Analysis chain
Verify the unit version for
org.yaml.snakeyaml.The version has been changed to
0.0.0. Ensure that this version is correct and intentional.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the version for `org.yaml.snakeyaml`. # Test: Check the available versions for the unit. Expect: The version `0.0.0` should be listed. curl -s https://download.eclipse.org/tools/cdt/releases/cdt-lsp-2.0/ | grep "org.yaml.snakeyaml"Length of output: 96
Script:
#!/bin/bash # Description: Verify the available versions for `org.yaml.snakeyaml` from Maven Central Repository. # Test: Check the available versions for the unit. Expect: The version `0.0.0` should be listed if it exists. curl -s "https://search.maven.org/solrsearch/select?q=g:org.yaml+AND+a:snakeyaml&rows=20&wt=json" | jq '.response.docs[] | .v'Length of output: 133
Script:
#!/bin/bash # Description: Verify the available versions for `org.yaml.snakeyaml` from Maven Central Repository. # Test: Check the available versions for the unit. Expect: The version `0.0.0` should be listed if it exists. curl -s "https://search.maven.org/solrsearch/select?q=g:org.yaml+AND+a:snakeyaml&rows=100&wt=json" | jq '.response.docs[] | .v'Length of output: 134
Script:
#!/bin/bash # Description: Verify the available versions for `org.yaml.snakeyaml` from the GitHub repository. # Test: Check the available versions for the unit. Expect: The version `0.0.0` should be listed if it exists. curl -s "https://api.github.com/repos/snakeyaml/snakeyaml/releases" | jq '.[].tag_name'Length of output: 87
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- releng/com.espressif.idf.target/com.espressif.idf.target.target (1 hunks)
Additional comments not posted (2)
releng/com.espressif.idf.target/com.espressif.idf.target.target (2)
91-91: Verify the new repository location.The repository location has been updated to
https://download.eclipse.org/tools/cdt/releases/cdt-lsp-2.0/. Ensure that this URL is correct and accessible.Verification successful
The new repository location is correct and accessible.
The URL
https://download.eclipse.org/tools/cdt/releases/cdt-lsp-2.0/returned a status code of 200, confirming its accessibility.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the accessibility of the new repository location. # Test: Access the new repository URL. Expect: HTTP status 200. curl -I https://download.eclipse.org/tools/cdt/releases/cdt-lsp-2.0/Length of output: 843
92-92: Verify the unit version fororg.eclipse.cdt.lsp.feature.feature.group.The version has been changed to
0.0.0. Ensure that this version is correct and intentional.
kolipakakondal
force-pushed
the
IEP-1291
branch
from
06c19de
to
a70dc48
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/LspService.java (1)
43-45: Enhance exception logging for broader catch block.Handling
Exceptioncan mask specific issues. Ensure logging provides enough context to diagnose problems effectively.- Logger.log(e); + Logger.log("Error restarting LSP server: ", e);
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/LspService.java (2 hunks)
- bundles/com.espressif.idf.lsp/src/com/espressif/idf/lsp/preferences/IDFClangdOptionsDefaults.java (3 hunks)
- releng/com.espressif.idf.target/com.espressif.idf.target.target (5 hunks)
Additional comments not posted (10)
bundles/com.espressif.idf.lsp/src/com/espressif/idf/lsp/preferences/IDFClangdOptionsDefaults.java (7)
Line range hint
28-33: LGTM! Clangd path retrieval is robust.The method uses
Optionalto handle null values gracefully, ensuring a default path is returned if necessary.
37-41: LGTM! Toolchain path handling is effective.The method appropriately uses
Optionalto handle null values, ensuring an empty string is returned when necessary.
45-48: LGTM! Default configuration for useTidy is clear.The method returns a fixed value, which is suitable for a default configuration.
51-54: LGTM! Default configuration for useBackgroundIndex is clear.The method returns a fixed value, which is suitable for a default configuration.
57-60: LGTM! Default completion style is set.The method returns a fixed string, which is appropriate for defining a default style.
63-66: LGTM! Default configuration for prettyPrint is clear.The method returns a fixed value, which is suitable for a default configuration.
69-72: LGTM! Default additional options are set.The method returns an empty list, which is a sensible default for additional options.
bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/LspService.java (1)
11-12: LGTM! Import updates align with package restructuring.The changes in import statements reflect the updated package structure, ensuring correct references.
releng/com.espressif.idf.target/com.espressif.idf.target.target (2)
6-6: LGTM! Repository URL updates are correct.The URLs have been updated to the latest versions, ensuring access to the most recent updates and features.
Also applies to: 22-22, 98-98
99-103: LGTM! Dependency version updates are correct.The dependencies have been updated to the latest versions, ensuring compatibility and access to new features.
Also applies to: 137-138
|
@kolipakakondal hi ! Tested under: able to see clangd preferences ✅ LGTM 👍 |
Description
fix #1017
Fixes # (IEP-1291)
Fix the below problem and this appears while building a project with 3.0.0 release + Eclipse 2024-06
Type of change
How has this been tested?
Test Case 1:
Test Case 2:
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Chores