SWTBot test case: DebugLaunchConfigTest #795
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmaaa
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Hi @AndriiFilippov. Thanks for the PR. I have written some comments about what we can improve.
....test/src/com/espressif/idf/ui/test/executable/cases/project/NewEspressifIDFProjectTest.java
Outdated
Show resolved
Hide resolved
....test/src/com/espressif/idf/ui/test/executable/cases/project/NewEspressifIDFProjectTest.java
Outdated
Show resolved
Hide resolved
....test/src/com/espressif/idf/ui/test/executable/cases/project/NewEspressifIDFProjectTest.java
Outdated
Show resolved
Hide resolved
....test/src/com/espressif/idf/ui/test/executable/cases/project/NewEspressifIDFProjectTest.java
Outdated
Show resolved
Hide resolved
....test/src/com/espressif/idf/ui/test/executable/cases/project/NewEspressifIDFProjectTest.java
Outdated
Show resolved
Hide resolved
....test/src/com/espressif/idf/ui/test/executable/cases/project/NewEspressifIDFProjectTest.java
Outdated
Show resolved
Hide resolved
alirana01
reviewed
Jul 18, 2023
There was a problem hiding this comment.
@AndriiFilippov good job on the first PR. @sigmaaa has given enough feedback that if fixed we can push the changes to master
....test/src/com/espressif/idf/ui/test/executable/cases/project/NewEspressifIDFProjectTest.java
Outdated
Show resolved
Hide resolved
…s name + update ActualExe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add SWTBot test case to check the match of the project name, Actual Executable, and SVD Path in the New ESP-IDF GDB OpenOCD Debugging Launch Configuration.
Fixes # (IEP-989)
Type of change
How has this been tested?
Checklist