EIM-57 Instalation UI improved for cases of installing multiple versions #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hahihula
requested review from
kolipakakondal,
brianignacio5 and
Fabricio-ESP
Fabricio-ESP
approved these changes
Nov 4, 2024
brianignacio5
approved these changes
Nov 5, 2024
| switch (event.payload.action) { | ||
| case 'start': | ||
| this.tools[event.payload.tool] = { | ||
| this.tools[this.curently_installing_version][event.payload.tool] = { |
There was a problem hiding this comment.
While unlikely it would be good to add validation here for this.curently_installing_version which need state == "started" otherwise it will be undefined to avoid undefined key error here.
Also typo this.currently_installing_version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.